Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11497] If an org has only one collection, check it by default #10806

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

szh
Copy link
Contributor

@szh szh commented Aug 29, 2024

🎟️ Tracking

https://github.com/orgs/bitwarden/discussions/10760

📔 Objective

When saving a password into an organization, if there's only one collection available to save to, select it by default. This improves UX by decreasing the number of clicks required.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@szh szh requested a review from a team as a code owner August 29, 2024 23:32
@szh szh requested a review from cd-bitwarden August 29, 2024 23:32
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-11497

@bitwarden-bot bitwarden-bot changed the title If an org has only one collection, check it by default [PM-11497] If an org has only one collection, check it by default Aug 29, 2024
@Jingo88 Jingo88 self-requested a review September 16, 2024 15:04
@Jingo88 Jingo88 added the needs-qa Marks a PR as requiring QA approval label Sep 16, 2024
@Jingo88 Jingo88 removed the needs-qa Marks a PR as requiring QA approval label Oct 7, 2024
@Jingo88
Copy link
Contributor

Jingo88 commented Oct 7, 2024

This has been approved by QA and merged. Thanks for the contribution!

@Jingo88 Jingo88 merged commit a4123cb into bitwarden:main Oct 7, 2024
120 of 135 checks passed
@szh
Copy link
Contributor Author

szh commented Oct 16, 2024

Thank you for merging this! Where should I look for the equivalent code in the mobile apps?

@KatherineInCode
Copy link

Hi! 👋🏻 The place where that would be figured out on iOS is in the VaultItemCoordinator, moving into the AddEditItemProcessor and its state/view objects.

@aj-rosado
Copy link
Contributor

Hello!
For Android, on the VaultAddEditViewModel, the method that deals with the org change is the handleOwnershipTextInputChange

handleCollectionSelect might also be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants