Commit 9f0fc00
First version of refactor (#25)
* First version of refactor
* Module update
* Rename `ssh` package
* Use chmod mode
* Refactor
* Write test
* Revert unintended `bitrise.yml` change
* Fixed mock to use `os` instead of new `fs`
* Refactor env and command handling
* Fixed missing export of `SSH_AUTH_SOCK`
* Add createStep func to initialise the step with default deps.
* Introduce log.Logger interface.
* Introduce FileWriter interface.
* Introduce command and env packages.
* Cleanup
* Update gitignore.
* Add test for ssh-add failure (#27)
* Add test for ssh-add failure
* More precise mocking of commands
* Extract command.Factory creation
* Step 1170 test sshkey add (#28)
* Test if ssh-add script is written in file and invoked via bash -c .
* Test if sshkey agent add is called after agent restart.
* Fix sshkey import path.
* Move sshkey add script filename to a const.
* Rename test.
* Rename test case.
* Update unit tests' comments.
* Rename tests.
* New command package. (#31)
* New command package.
* Rename command package structs.
* Update tests.
* Revert ListKeys unintentionl change.
* Step 1170 envs (#34)
* Introduce env.Repository.
* Code cleanup.
* command package appends envs to os.Environ by default.
* Update tests.
* Break command's os dependency.
* Applying changes made in `go-utils` and `go-steputils` respectively
TODOs:
* Decide how to control verbose logging (after reading config?)
* Move mocks to the libraries to avoid mock generation duplication
* Split and cleanup tests
* Currently `go-steputils` is on branch `envman-aware-environment`
Revert back to track latest master when said branch is merged
* Prevent `errcheck` failure on mocks
[WIP]
* Update go-steputils
* Update go-utils/log package (#35)
* Update go-utils/log package.
* Pull latest go-utils package.
* Fix SSH_AUTH_SOCK env for ssh key add command.
* Use stepconf.EnvParser
* Use mocks from go-utils (#36)
* Use mocks from go-utils
* Update go-utils, remove duplicate import
* Update go-steputils/stepconf package. (#37)
* Move SSHKeyAgent interface and mock to the sshkey package. (#38)
Co-authored-by: Krisztián Gödrei <[email protected]>
Co-authored-by: Olivér Falvai <[email protected]>1 parent 4681450 commit 9f0fc00
File tree
99 files changed
+25640
-974
lines changed- activatesshkey
- sshkey
- mocks
- step
- vendor
- github.com
- bitrise-io
- go-steputils
- stepconf
- stepenv
- tools
- go-utils
- command
- mocks
- env
- mocks
- fileutil
- mocks
- log
- mocks
- pathutil
- mocks
- davecgh/go-spew
- spew
- pmezard/go-difflib
- difflib
- stretchr
- objx
- testify
- assert
- mock
- gopkg.in/yaml.v3
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
99 files changed
+25640
-974
lines changedThis file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
8 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| 19 | + | |
15 | 20 | | |
16 | 21 | | |
17 | 22 | | |
18 | | - | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 25 | + | |
25 | 26 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | 27 | | |
30 | | - | |
| 28 | + | |
31 | 29 | | |
32 | | - | |
33 | | - | |
34 | 30 | | |
35 | 31 | | |
36 | 32 | | |
37 | | - | |
38 | | - | |
| 33 | + | |
| 34 | + | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
| |||
0 commit comments