Handle 5xx trigger errors (#227)

Currently, if build triggering fails with an internal error,
the service responds with an 4xx error. Some consumers (including one of ours) would build a retry mechanism on top of error codes,
and wouldn't retry a 400 error, this would result in "losing"
that build trigger request.

Please note that theoretically an input param validation can also result
in the same Errors field being populated and thus a 5xx error.
We don't see any validation error though in the recent logs,
so we propose to deal with this later as being able to separate between
these errors would require some additional refactoring.

Author: gaborszakacs

bitriseapi/bitriseapi.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"log"
 	"net/http"
 	"net/url"
@@ -203,12 +203,16 @@ func TriggerBuild(url *url.URL, apiToken string, params TriggerAPIParamsModel, i
 		}
 	}()
 
-	body, err := ioutil.ReadAll(resp.Body)
+	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return TriggerAPIResponseModel{}, false, errors.Wrapf(err, "TriggerBuild (url:%s): request sent, but failed to read response body (http-code:%d)", url.String(), resp.StatusCode)
 	}
 	bodyString := string(body)
 
+	if resp.StatusCode >= 500 || resp.StatusCode < 600 {
+		return TriggerAPIResponseModel{}, false, errors.Wrapf(err, "TriggerBuild (url:%s): request sent, but received a server error response (http-code:%d, response body:%s)", url.String(), resp.StatusCode, bodyString)
+	}
+
 	var respModel TriggerAPIResponseModel
 	if err := json.Unmarshal(body, &respModel); err != nil {
 		return TriggerAPIResponseModel{}, false, errors.Wrapf(err, "TriggerBuild (url:%s): request sent, but failed to parse response (http-code:%d, response body:%s)", url.String(), resp.StatusCode, bodyString)

service/hook/common/default_response_provider.go

@@ -5,8 +5,7 @@ import (
 )
 
 // DefaultResponseProvider ...
-type DefaultResponseProvider struct {
-}
+type DefaultResponseProvider struct{}
 
 // SingleErrorRespModel ...
 type SingleErrorRespModel struct {
@@ -40,7 +39,7 @@ func (hp DefaultResponseProvider) TransformResponse(input TransformResponseInput
 	}
 
 	if len(input.Errors) > 0 {
-		httpStatusCode = 400
+		httpStatusCode = 500
 	}
 
 	if len(input.FailedTriggerResponses) > 0 {