Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana-tempo] Support of scaling single binary mode #30855

Open
rim99 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #31028
Open

[grafana-tempo] Support of scaling single binary mode #30855

rim99 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #31028
Assignees

Comments

@rim99
Copy link

rim99 commented Dec 10, 2024

Name and Version

bitnami/grafana-tempo

What is the problem this feature will solve?

Support new type of Tempo running mode: https://grafana.com/docs/tempo/latest/setup/deployment/#scaling-monolithic-mode

It would help to maintain a reasonable size of cluster handling small to medium volumes of incoming traces

What is the feature you are proposing to solve the problem?

Create a statefulset, in which pods are started with arg -target=scalable-single-binary. All pods can stay in the same gossip ring as a cluster

@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

@rim99
Copy link
Author

rim99 commented Dec 13, 2024

Hi @carrodher , I've tested my changes with minikube locally. New statefulset works fine as a cluster.

Regarding the VIB test, how to achieve 2 different sets of env for testing?
Since it should test both cases: tempo.deploymentMode=microservices and tempo.deploymentMode=scalingMonolithic

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review it and provide feedback. Please ask about testing scenarios in the PR itself. The reviewers will help you there since they have the whole context.
Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants