[bitnami/keycloak] Issue with metrics into ServiceMonitor #30370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and master realm metrics. Signed-off-by: Renaud Demarneffe <[email protected]>
Signed-off-by: Renaud Demarneffe <[email protected]>
carrodher
reviewed
Nov 9, 2024
| @@ -1011,7 +1011,8 @@ metrics: | |||
| ## @param metrics.service.ports.http Metrics service HTTP port | |||
| ## | |||
| ports: | |||
| http: 9000 | |||
| metrics: 9000 | |||
There was a problem hiding this comment.
Thanks for your contribution. Please note you need to add the metadata for this new parameter, see the above metadata corresponding to the already existing parameters.
Signed-off-by: Renaud Demarneffe <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Thanks a lot @RDemarneffe, in #30095 didn't see that instance and realm metrics were using different interfaces. Great work!
I was revisiting monitoring features and WDYT about this:
charts/bitnami/keycloak/values.yaml
Lines 1015 to 1019 in 089c308
I think is worth to change it with something like this:
## @param metrics.service.annotations [object] Annotations for enabling prometheus to access the metrics endpoints
##
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "{{ .Values.metrics.service.ports.metrics }}"
prometheus.io/path: "{{ (.Values.metrics.serviceMonitor.endpoints | first).path }}"
|
@RDemarneffe This has been fixed by #30303, merged yesterday |
|
Thanks @RDemarneffe. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow using different ports into ServiceMonitor for instance metrics and master realm metrics.
Benefits
Correctly configure prometheus for grabbing metrics.
Possible drawbacks
None.
Applicable issues
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm