Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a notification at sync when ContentProvider inaccessible #1278

Draft
wants to merge 2 commits into
base: main-ose
Choose a base branch
from
Draft

Show a notification at sync when ContentProvider inaccessible #1278

wants to merge 2 commits into from

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 30, 2025 •
edited
Loading

Purpose

When content providers like contacts or calendar storage are inaccessible we can not sync and should notify the user about it.

Short description

  • extract the notification handling from SyncManager
  • send notification when content provider inacessible

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the enhancement New feature or request label Jan 30, 2025
@sunkup sunkup self-assigned this Jan 30, 2025
@sunkup sunkup linked an issue Jan 30, 2025 that may be closed by this pull request
Show a notification at sync when ContentProvider inaccessible #1253
Open
@sunkup sunkup force-pushed the 1253-show-a-notification-at-sync-when-contentprovider-inaccessible branch 2 times, most recently from e2dbbbe to 16f5994 Compare February 3, 2025 16:06
@sunkup sunkup force-pushed the 1253-show-a-notification-at-sync-when-contentprovider-inaccessible branch from 16f5994 to d1a3ae6 Compare February 5, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sunkup sunkup

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a notification at sync when ContentProvider inaccessible
1 participant
@sunkup