Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip login type selection when logging in via intent #1267

Open
wants to merge 6 commits into
base: main-ose
Choose a base branch
from
Open

Skip login type selection when logging in via intent #1267

wants to merge 6 commits into from

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 27, 2025 •
edited
Loading

Purpose

When DAVx5 is opened via intent containing a valid Email or URL (not nextcloud login flow), there is no need to show the login type page. We should open either the Email or URL login page directly.

Short description

  • Add support for "mailto" scheme
  • Always skip login type page if not default login type (Email, URL or Nextcloud)

Use for testing:

adb shell am start -d caldavs://user:[email protected]:444/path at.bitfire.davdroid/.ui.setup.LoginActivity

adb shell am start -d mailto:[email protected] at.bitfire.davdroid/.ui.setup.LoginActivity

adb shell am start -d mailto:[email protected] --es password 123 at.bitfire.davdroid/.ui.setup.LoginActivity

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the bug Something isn't working label Jan 27, 2025
@sunkup sunkup self-assigned this Jan 27, 2025
@sunkup sunkup linked an issue Jan 27, 2025 that may be closed by this pull request
Login over Intent doesn't directly go to correct login page #1244
Open
2 tasks
@sunkup sunkup force-pushed the 1244-login-over-intent-doesnt-directly-go-to-correct-login-page branch 4 times, most recently from 15ab34e to 7b6d20a Compare January 30, 2025 12:14
@sunkup sunkup requested a review from ArnyminerZ January 30, 2025 12:22
@sunkup sunkup marked this pull request as ready for review January 30, 2025 12:22
@sunkup sunkup force-pushed the 1244-login-over-intent-doesnt-directly-go-to-correct-login-page branch from 7b6d20a to 3a5b0b1 Compare February 3, 2025 14:41
ArnyminerZ
ArnyminerZ requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's not working correctly.

If I launch the provided CalDAV url, simply nothing happens, the add account screen shows up asking for login type.

If I launch the first mailto (without password), the "Login with email address" screen is shown, but no email is pre-filled.

If I launch the second mailto (with password), the "Login with email address" screen is shown, prefilled with the password, but the email is empty.

Edit: nvm

ArnyminerZ
ArnyminerZ approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it works correctly, for some reason after rebuilding it worked correctly.

@sunkup sunkup requested a review from rfc2822 February 5, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

@rfc2822 rfc2822 Awaiting requested review from rfc2822

Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login over Intent doesn't directly go to correct login page
2 participants
@sunkup @ArnyminerZ