Do not error on any AppT in sqlMaybeSelectProcessRowDec #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
reviewed
Nov 27, 2024
src/Database/Esqueleto/Record.hs
Outdated
| ((ConT ((==) ''Maybe -> True)) `AppT` _inner) -> AppE (ConE 'Just) | ||
| (ConT _) -> id | ||
| (AppT _ _) -> id | ||
| _ -> error $ show x |
There was a problem hiding this comment.
Do we want to keep the error here? I feel like we may want to just have id as the fallback case instead of erroring on unknown constructors
There was a problem hiding this comment.
I agree, done. only had the error in the first place to be more similar to pre-existing behavior.
parsonsmatt
approved these changes
Nov 27, 2024
No need to be this restrictive in deriveEsqueletoRecord For example, AppT ListT _ and AppT (ConT _) _ are both fine but would throw an error here before this change.
parsonsmatt
approved these changes
Dec 5, 2024
|
Tested on the work codebase, all good! Uploaded as 3.5.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to be this restrictive in deriveEsqueletoRecord For example, AppT ListT _ and AppT (ConT _) _ are both fine but would throw an error here before this change.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR: