Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent 2.6 compatibility #8

Closed
bitemyapp opened this issue Jan 6, 2017 · 10 comments · Fixed by #12
Closed

Persistent 2.6 compatibility #8

bitemyapp opened this issue Jan 6, 2017 · 10 comments · Fixed by #12

Comments

@bitemyapp
Copy link
Owner

bitemyapp commented Jan 6, 2017

Title. Fair warning, I don't care about Esqueleto and Persistent having matchy-matchy versioning.

@mrkkrp
Copy link
Contributor

mrkkrp commented Jan 8, 2017

When can we expect persistent-2.6-compatible release? If you don't plan to work on this right now, I can try to allow 2.6 and see what breaks, then open a PR. It'd be nice to get 2.6-compatibility by next week (16 January), I'm ready to spend some time to make it happen, although it looks like no serious changes are necessary (according to persistent changelog, it should be enough to just bump upper bound).

@peti
Copy link

peti commented Jan 9, 2017

What about prowdsponsor/esqueleto#149? That patch seems to work fine.

@bitemyapp
Copy link
Owner Author

It's possible we ate the cost of a compat break already for 2.5. I'm not sure if enolan's PR is based on the 2.5 variant I used in this repo.

I'm at a conf until the end of the week, so I can't investigate this just yet (I'd be foggy), but if someone starts kicking around a PR and tells me what breaks it'll definitely happen sooner.

@qrilka
Copy link
Contributor

qrilka commented Jan 17, 2017

@bitemyapp any plans of a new release with this issue resolved?

@nd2s
Copy link

nd2s commented Jan 22, 2017

Would be good if there were a release very soon so it can finally be used with lts-7.x.

@bitemyapp
Copy link
Owner Author

screenshot from 2017-01-22 12-55-39

@mrkkrp
Copy link
Contributor

mrkkrp commented Jan 22, 2017

🎉 Now it can be enabled on Stackage.

@nd2s
Copy link

nd2s commented Jan 22, 2017

@bitemyapp Great - many thanks!

@peti
Copy link

peti commented Jan 22, 2017

@bitemyapp, how do you get your shell to add that little check-mark to the prompt for non-error exit codes? Is that bash?

@bitemyapp
Copy link
Owner Author

@peti that's not what it does, it's a dirty check for my Git repository so that I don't forget to check things in.

My entire dev env is and always has been public: github.com/bitemyapp/dotfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants