Pass custom property types through #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a further issue with this which I believe we can fix forward. If a custom class is defined and nested inside another custom class with its default behaviour, then the values do not get pulled through. As an example: This Yields the following XML
However, if we modifiy the component (notice the bold) The XML is now
Obviously this isn't handled anywhere currently in PyTMX. You can workaround this by modifying the value of the custom class but that's a workaround rather than a fix. A proposed fix would be to pull in the default values if none have been overridden |
|
On second thought I'm not sure if above is even a bug. It might be a config option:
Haven't had time to take a look but I don't think it should stop the PR going out either way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entirely piggybacking off of @xivol by raising this but this fixes issues with custom types and custom classes.
I have tested it via Tiled.
In Tiled I have the following objects and its custom classes:
And here a demo of the custom classes working (i.e. being read from pytmx)
figs-custom-glass.mp4
Closes #184