Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before installing compiled binaries, check sudo permission #630

Open
bitcoin-tools opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1341
Open

Before installing compiled binaries, check sudo permission #630

bitcoin-tools opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1341

Comments

@bitcoin-tools
Copy link
Owner

bitcoin-tools commented Apr 30, 2024

Is your feature request related to a problem? Please describe.

The user will lose sudo permission after 5 minutes without using it.

Most computers will take more than 5 minutes to compile bitcoin, so we need a step that prompts the user for a password again.

  Compiling source code, please wait... ok.
  Running compile checks, please wait... ok.
  Installing Bitcoin Core... Password:
ok.
Checking data already synced... 4 GiB.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@bitcoin-tools
Copy link
Owner Author

bitcoin-tools commented May 30, 2024

Another approach would be to keep sudo alive, so we don't need to check for it.

keep_sudo_alive() {
    while true; do
        sudo -n true
        sleep 60 # Adjust the sleep time as needed
    done
}

keep_sudo_alive &
keep_sudo_alive_pid=$!
make
kill "${keep_sudo_alive_pid}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant