Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction details "virtual size" does not account for sigops #750

Open
luke-jr opened this issue Aug 25, 2023 · 0 comments
Open

Transaction details "virtual size" does not account for sigops #750

luke-jr opened this issue Aug 25, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@luke-jr
Copy link
Member

luke-jr commented Aug 25, 2023

    strHTML += "<b>" + tr("Transaction virtual size") + ":</b> " + QString::number(GetVirtualTransactionSize(*wtx.tx)) + " bytes<br>";

GetVirtualTransactionSize fails to account for sigops if passed the transaction alone.

This could confuse a user into thinking the transaction they were sent, still unconfirmed, has a reasonable fee rate, when it might very well not due to a bunch of sigops in another output or input.

Annoyingly, GetTransactionSigOpCost looks liable to assert if used on a confirmed transaction. It wouldn't make sense to stop reporting the correct virtual size after a transaction confirms, so this looks like a pain to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant