{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":272700405,"defaultBranch":"master","name":"gui","ownerLogin":"bitcoin-core","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-06-16T12:20:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13464320?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1621257589.5340319","currentOid":""},"activityList":{"items":[{"before":"b52d54736168bed82775e3c9e66c6320c7b83626","after":"5abb9b1af49be9024f95fa2f777285c531785d85","ref":"refs/heads/master","pushedAt":"2024-09-01T08:53:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30763: doc: update Fedora build instructions for cmake\n\n877c55a68b65b30f226f4747829bc7336329e295 doc: update fedora build instructions for cmake (Marnix)\n\nPull request description:\n\n  Update Fedora build instructions for cmake:\n\n  - update the Fedora build requirements\n  - remove old configure instruction\n\n  This was forgotten to update\n\nACKs for top commit:\n  davidgumberg:\n    ACK https://github.com/bitcoin/bitcoin/commit/877c55a68b65b30f226f4747829bc7336329e295\n  l0rinc:\n    utACK 877c55a68b65b30f226f4747829bc7336329e295\n  hebasto:\n    ACK 877c55a68b65b30f226f4747829bc7336329e295.\n  pablomartin4btc:\n    ACK 877c55a68b65b30f226f4747829bc7336329e295\n  tdb3:\n    ACK 877c55a68b65b30f226f4747829bc7336329e295\n\nTree-SHA512: 53fbd4bef96d2aeef753f26359eab53023a154fbcc75952aecd15e8805cc24ceb8ebdc6d8746416720b5655ed694299b3381a2e4d621ebd522fb09d145c48665","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2496927344\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30763\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30763/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30763\">bitcoin/bitcoin#30763</a>: doc: update Fedora build instructions fo…"}},{"before":"e96f657e20fd52a555dbfd1dd2f63892560f4f1c","after":"b52d54736168bed82775e3c9e66c6320c7b83626","ref":"refs/heads/master","pushedAt":"2024-08-31T14:18:14.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"ryanofsky","name":"Ryan Ofsky","path":"/ryanofsky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7133040?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30377: refactor: Replace ParseHex with consteval \"\"_hex literals\n\n8756ccd71218c8e013181473720b10d3c4a94957 scripted-diff: Replace ParseHex[<std::byte>](\"str\") -> \"str\"_hex[_u8] (Hodlinator)\n9cb687351f7ff50d19b5c5997ed69cfdab75bbf2 refactor: Prepare for ParseHex -> \"\"_hex scripted-diff (Hodlinator)\n50bc017040ae300c795e3709233b80619db24518 refactor: Hand-replace some ParseHex -> \"\"_hex (Hodlinator)\n5b74a849cf5c54543280ba6488ae7f87361b1e2f util: Add consteval \"\"_hex[_v][_u8] literals (l0rinc)\ndc5f6f681275f56ff389500e3dd98fbe791f4a45 test refactor: util_tests - parse_hex clean up (Hodlinator)\n2b5e6eff36abe4c23b8789ef1babfafedc90b973 refactor: Make XOnlyPubKey tolerate constexpr std::arrays (Hodlinator)\n403d86f1ccf0b73f042d42a9722bb007ba8c7a31 refactor: vector -> span in CCrypter (Hodlinator)\nbd0830bbd4105af1953b6b897ba6bc35098cbe13 refactor: de-Hungarianize CCrypter (Hodlinator)\nd99c81697148a9695c0fba614dff9fbe728a3acd refactor: Improve CCrypter related lines (Hodlinator)\n7e1d9a84689d77a9349a3a09fd5f9dd3f9c293aa refactor: Enforce lowercase hex digits for consteval uint256 (Hodlinator)\n\nPull request description:\n\n  Motivation:\n  * Validates and converts the hex string into bytes at compile time instead of at runtime like `ParseHex()`.\n  * Eliminates runtime dependencies: https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2214432177, https://github.com/bitcoin/bitcoin/pull/30048#discussion_r1592108480\n  * Has stricter requirements than `ParseHex()` (disallows whitespace and uppercase hex digits) and replaces it in a bunch of places.\n  * Makes it possible to derive other compile time constants.\n  * Minor: should shave off a few runtime CPU cycles.\n\n  `\"\"_hex` produces `std::array<std::byte>` as the momentum in the codebase is to use `std::byte` over `uint8_t`.\n\n  Also makes `uint256` hex string constructor disallow uppercase hex digits. Discussed: https://github.com/bitcoin/bitcoin/pull/30560#discussion_r1701323070\n\n  Surprisingly does not change the size of the Guix **bitcoind** binary (on x86_64-linux-gnu) by 1 single byte.\n\n  Spawned already merged PRs: #30436, #30482, #30532, #30560.\n\nACKs for top commit:\n  l0rinc:\n    ACK 8756ccd71218c8e013181473720b10d3c4a94957\n  stickies-v:\n    Rebase re-ACK 8756ccd71218c8e013181473720b10d3c4a94957, no changes since a096215c9c71a2ec03e76f1fd0bcdda0727996e0\n  ryanofsky:\n    Code review ACK 8756ccd71218c8e013181473720b10d3c4a94957, just rebasing since last review and taking advantage of CScript constructors in #29369, also tweaking a code comment\n\nTree-SHA512: 9b2011b7c37e0ef004c669f8601270a214b388916316458370f5902c79c2856790b1b2c7c123efa65decad04886ab5eff95644301e0d84358bb265cf1f8ec195","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2385915578\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30377\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30377/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30377\">bitcoin/bitcoin#30377</a>: refactor: Replace ParseHex with consteva…"}},{"before":"96b0a8f858ab24f3672360b8c830553b963de726","after":"e96f657e20fd52a555dbfd1dd2f63892560f4f1c","ref":"refs/heads/master","pushedAt":"2024-08-31T11:07:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30777: ci: Delete no longer needed workaround\n\n74da8cb286ce057cbd8c5081bac3fda74781c279 ci: Delete no longer needed workaround (Hennadii Stepanov)\n\nPull request description:\n\n  This PR removes a workaround that was necessary at some point during the development of the CMake staging branch.\n\nACKs for top commit:\n  fanquake:\n    ACK 74da8cb286ce057cbd8c5081bac3fda74781c279\n\nTree-SHA512: 619a513efe86af8e24fc3b6e4124df8f3ff3699216a3f87a4385aeb5e3c605f2b035d1594604cd3efe66281ac879d954d412ee4ae8423408e46ebd32956883a5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2498578597\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30777\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30777/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30777\">bitcoin/bitcoin#30777</a>: ci: Delete no longer needed workaround"}},{"before":"c91cabbf5664bb3828bcdaed686d8e6b177068aa","after":"96b0a8f858ab24f3672360b8c830553b963de726","ref":"refs/heads/master","pushedAt":"2024-08-30T16:40:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30752: guix: Drop unused autotools packages\n\n0004dcc7b136424e5c84c3750e9d6af336b674ed guix: Drop unused autotools packages (Hennadii Stepanov)\n\nPull request description:\n\n  This PR implements https://github.com/hebasto/bitcoin/pull/294.\n\n  From https://github.com/hebasto/bitcoin/pull/294#issuecomment-2317292100:\n  > I think guix was already bumped to cmake, so this can be done in a separate pull already today?\n\nACKs for top commit:\n  fanquake:\n    ACK 0004dcc7b136424e5c84c3750e9d6af336b674ed\n\nTree-SHA512: 60d0be8df6340797bebcd6a734e2a5a0a24df18b65c174af47ea652110f26aca00b019dd205b83ae0e664ba1322628f252ade461d2dc01353045347d405ad5fa","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2494102438\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30752\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30752/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30752\">bitcoin/bitcoin#30752</a>: guix: Drop unused autotools packages"}},{"before":"3ee1521c048a41bc1e876d90261db677ec958f72","after":"c91cabbf5664bb3828bcdaed686d8e6b177068aa","ref":"refs/heads/master","pushedAt":"2024-08-30T13:04:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30753: build: Drop no longer needed workaround\n\n66dd1b4e58347327c14e5d9a26ce41592b07113f build: Drop no longer needed workaround (Hennadii Stepanov)\n\nPull request description:\n\n  This PR deletes a workaround that is no longer needed since https://github.com/bitcoin/bitcoin/pull/30508 was merged.\n\nACKs for top commit:\n  fanquake:\n    ACK 66dd1b4e58347327c14e5d9a26ce41592b07113f\n\nTree-SHA512: abb8e79b525989afe88f94899e4dc29c80d4593ea23f44c6b3d08710e6ddd1619e748798534973fa4ee9f48d9fad7226445b7a2cb4aec0bdb5d1b7ff2f6689ea","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2494416238\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30753\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30753/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30753\">bitcoin/bitcoin#30753</a>: build: Drop no longer needed workaround"}},{"before":"ffdc3d6060f6e65e69cf115a13b83e6eb4a0a0a8","after":"3ee1521c048a41bc1e876d90261db677ec958f72","ref":"refs/heads/master","pushedAt":"2024-08-30T08:51:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30730: guix: Bump time machine to 53396a22afc04536ddf75d8f82ad2eafa5082725\n\n60d4398a345cb0be600fcced3abd37219a105d57 guix: drop GCC 12.4.0 package (fanquake)\n5ed1511e5032dc3e229e91701580e2a7e3146b2f guix: bump time-machine to 53396a22afc04536ddf75d8f82ad2eafa5082725 (fanquake)\n\nPull request description:\n\n  Followup to #30511.\n  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=9aa38f98cbd41644abe2c43bb4f44f74df642df2 landed.\n\n  Linux headers `6.1.102` -> `6.1.106`\n\nACKs for top commit:\n  hebasto:\n    ACK 60d4398a345cb0be600fcced3abd37219a105d57.\n  TheCharlatan:\n    ACK 60d4398a345cb0be600fcced3abd37219a105d57\n\nTree-SHA512: 6ff4372897e5abb15c28d4607915f777585d54b7a35787ac46f7ddca0d695dc60a7da532d8beb37e2df1de12511220f0dc6428f68d6a4db628de816e2d339914","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2491751083\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30730\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30730/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30730\">bitcoin/bitcoin#30730</a>: guix: Bump time machine to 53396a22afc04…"}},{"before":"1e4823870054c3af53619173389376e03174c283","after":"ffdc3d6060f6e65e69cf115a13b83e6eb4a0a0a8","ref":"refs/heads/master","pushedAt":"2024-08-29T16:34:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30754: misc: Autotools -> CMake changes\n\na865494deeff7dedcad7140299aee00ab3cdd62c lint: remove autotools packages (fanquake)\nb02f29e7efa5043791a6574a3f0355750aab1ea1 doc: replace Autotools with CMake (fanquake)\n\nPull request description:\n\n  These don't seem to be included in, i.e #30664.\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK a865494deeff7dedcad7140299aee00ab3cdd62c\n  hebasto:\n    re-ACK a865494deeff7dedcad7140299aee00ab3cdd62c.\n\nTree-SHA512: bafa2675d7c819478fb9b3f44f557ec767acb8fa3c4a191b1b8a1e47352a4cb6cebbb3138d961058d846926359f5451241a8badcbe3edd7e067d69ecfc45df93","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2494721386\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30754\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30754/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30754\">bitcoin/bitcoin#30754</a>: misc: Autotools -&gt; CMake changes"}},{"before":"7349d572c34ebf2863ecd0d12793a1efc6f21ab2","after":"1e4823870054c3af53619173389376e03174c283","ref":"refs/heads/master","pushedAt":"2024-08-29T14:48:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30714: test: fix `TestShell` initialization (late follow-up for #30463)\n\nbd7ce05f9d9d21903163a2bd9dd2df3ed3990c3e test: fix `TestShell` initialization (late follow-up for #30463) (Sebastian Falbesoner)\n\nPull request description:\n\n  Creating a `TestShell` instance as stated in the [docs](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test-shell.md) currently fails on master:\n  ```\n  $ python3\n  Python 3.10.13 (main, Mar 15 2024, 07:36:23) [Clang 16.0.6 ] on openbsd7\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n  >>> import sys\n  >>> sys.path.insert(0, \"/home/thestack/bitcoin/test/functional\")\n  >>> from test_framework.test_shell import TestShell\n  >>> test = TestShell().setup(num_nodes=2, setup_clean_chain=True)\n  Traceback (most recent call last):\n    File \"<stdin>\", line 1, in <module>\n    File \"/home/thestack/bitcoin/test/functional/test_framework/test_shell.py\", line 70, in __new__\n      TestShell.instance = TestShell.__TestShell()\n  TypeError: BitcoinTestFramework.__init__() missing 1 required positional argument: 'test_file'\n  ```\n  Since #30463, BitcoinTestFramework instances expect the path of the calling test at construction, in order to find shared data like the configuration (config.ini) and the cache. Note that in contrast to actual functional tests, we can't simply pass `__file__` here, as the test shell module sits within the `test_framework` subfolder, so we have to navigate up to the parent directory and append some dummy test file name.\n\n  On the long-term we should probably add some TestShell instantation smoke-test to detect issues like this early. As I'm not too familiar with the CI I'm not sure what is a good way to achieve this (a functional test obviously can't be used, as that's already a BitcoinTestFramework test in itself), but happy to take suggestions.\n\nACKs for top commit:\n  ismaelsadeeq:\n    Tested ACK bd7ce05f9d9d21903163a2bd9dd2df3ed3990c3e\n  danielabrozzoni:\n    tACK bd7ce05f9d9d21903163a2bd9dd2df3ed3990c3e\n  brunoerg:\n    ACK bd7ce05f9d9d21903163a2bd9dd2df3ed3990c3e\n\nTree-SHA512: c3a2365e2cda48a233ee724673c490787981354914f33e10eadbbad9c68e8403d84c5551229a611401e743886539de380ba4bfcb77032b6c85731e3bbe962dc1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2485426856\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30714\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30714/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30714\">bitcoin/bitcoin#30714</a>: test: fix <code>TestShell</code> initialization (la…"}},{"before":"5c7d4b9dec7977ee697c64c290c96f69d53d0884","after":"7349d572c34ebf2863ecd0d12793a1efc6f21ab2","ref":"refs/heads/master","pushedAt":"2024-08-29T14:46:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30701: Use MiniWallet in functional test rpc_signrawtransactionwithkey.\n\na563f41232e2dd360ee8e76f6348dd10c7f4f2a3 Remove second node since only 1 is needed for the test (Martin Saposnic)\n1f4cdb3d69926eedb6ed9376f30c4eefcf610a0c Replace custom funding tx creation with MiniWallet. (Martin Saposnic)\n\nPull request description:\n\n  In response to issue https://github.com/bitcoin/bitcoin/issues/30600, optimizations have been implemented to enhance test efficiency and readability:\n\n  This PR refactors the `rpc_signrawtransactionwithkey.py` functional test to use MiniWallet for creating funding transactions. This simplifies the test code and improves performance by eliminating the need to mine new blocks for each funding transaction.\n\n  Key changes:\n  - Replaced custom `send_to_address` method with MiniWallet's `send_to` method\n  - Removed unnecessary setup of a clean chain and second node\n  - Simplified transaction creation and signing process\n\nACKs for top commit:\n  glozow:\n    ACK a563f41232e2dd360ee8e76f6348dd10c7f4f2a3\n  ismaelsadeeq:\n    code review ACK a563f41232e2dd360ee8e76f6348dd10c7f4f2a3\n  theStack:\n    ACK a563f41232e2dd360ee8e76f6348dd10c7f4f2a3\n\nTree-SHA512: 318959f89702b169453d537dafb822f5ef1921db1088941d8bbdb3171dd7a6ecad590e57a3802bc37bcf8992267ed6ffa7f156b229d9817ebf812bd35df509b5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2481876270\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30701\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30701/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30701\">bitcoin/bitcoin#30701</a>: Use MiniWallet in functional test rpc_si…"}},{"before":"7a226eb4d97bb76cd8c13afe4ec7c0aab5046b13","after":"5c7d4b9dec7977ee697c64c290c96f69d53d0884","ref":"refs/heads/master","pushedAt":"2024-08-29T11:30:18.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30749: Remove bsdmainutils from doc/ci\n\n78358ce09d2a62a469a544249e02e02f9f7b94cd ci: add libzmq3-dev to test-each-commit job (fanquake)\na2b1d2c5ec25a91e224c2b83a5588128e81c6faf doc: remove bsdmainutils (fanquake)\n36ff336d2e417977340c1f6ca70f55433ce8d9f8 ci: remove bsdmainutils (fanquake)\n\nPull request description:\n\n  This was previously used to install `hexdump` (for the tests). However that isn't used by CMake. I'm not aware of any other tools from this package being used.\n\nACKs for top commit:\n  maflcko:\n    ACK 78358ce09d2a62a469a544249e02e02f9f7b94cd\n  hebasto:\n    ACK 78358ce09d2a62a469a544249e02e02f9f7b94cd.\n\nTree-SHA512: 01c1be81feba03a9645e3d382067df4cd7c64de184871c8d9691053a8f871fcedf48d298303554560df2cb1949fb35d5ce9ff20c751ff35789b7689d656c0287","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2493914701\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30749\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30749/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30749\">bitcoin/bitcoin#30749</a>: Remove bsdmainutils from doc/ci"}},{"before":"d08bedd81f184808c274f3c49cf5d581ccc78468","after":"7a226eb4d97bb76cd8c13afe4ec7c0aab5046b13","ref":"refs/heads/master","pushedAt":"2024-08-29T10:40:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30653: guix: Drop unused module from manifest\n\nc7fb80a08f9825d6d21d4a5545f42255fea11f62 guix: Drop unused module from manifest (Hennadii Stepanov)\n\nPull request description:\n\n  My Guix build:\n  ```\n  x86_64\n  170df52c2238510bd166f3fb1c4c3c11d2c1480a2e468fd532cb4d0435ac11cf  guix-build-c7fb80a08f98/output/aarch64-linux-gnu/SHA256SUMS.part\n  54e71ef5135464f58e3db4a3b893fa2f26a2c9cfb465699a363bb59a0d1bd94f  guix-build-c7fb80a08f98/output/aarch64-linux-gnu/bitcoin-c7fb80a08f98-aarch64-linux-gnu-debug.tar.gz\n  806d6042151e0af026748379b9bbbfea53d4c91555b2f0d05ed11faf83f429bb  guix-build-c7fb80a08f98/output/aarch64-linux-gnu/bitcoin-c7fb80a08f98-aarch64-linux-gnu.tar.gz\n  96f111f81311b55c805f1ebe74c5a5bc3160819e8fc6d14aab778e6a20a5c266  guix-build-c7fb80a08f98/output/arm-linux-gnueabihf/SHA256SUMS.part\n  231a29a9ffec9cc88260324da28d8443a6fd455ff0b010574af455034581aea3  guix-build-c7fb80a08f98/output/arm-linux-gnueabihf/bitcoin-c7fb80a08f98-arm-linux-gnueabihf-debug.tar.gz\n  a545801e94e2a7a9859f0111be8762a2a7e5ea4636eed86ac95d17f2f4cdb37a  guix-build-c7fb80a08f98/output/arm-linux-gnueabihf/bitcoin-c7fb80a08f98-arm-linux-gnueabihf.tar.gz\n  f565c1c7c10cc5c36f2206c3c5aab54422f20e38185c43f4dbd91c12cb33d10d  guix-build-c7fb80a08f98/output/arm64-apple-darwin/SHA256SUMS.part\n  0b0d3d7e7300984063109f2ea23fabdf3961fa337ff28ed602a22965cdf6b499  guix-build-c7fb80a08f98/output/arm64-apple-darwin/bitcoin-c7fb80a08f98-arm64-apple-darwin-unsigned.tar.gz\n  78cfb54230e3b054c4bb121925844720be52269db6a63161eeebe93ebfb2dc21  guix-build-c7fb80a08f98/output/arm64-apple-darwin/bitcoin-c7fb80a08f98-arm64-apple-darwin-unsigned.zip\n  95124a8019053cc296187c0332e3b5b3acef401298baadacf52713068764dd99  guix-build-c7fb80a08f98/output/arm64-apple-darwin/bitcoin-c7fb80a08f98-arm64-apple-darwin.tar.gz\n  a8b36c808c7b57cb2a20e43af36749c07f14392b9816752b68a986f9124806fc  guix-build-c7fb80a08f98/output/dist-archive/bitcoin-c7fb80a08f98.tar.gz\n  f7221bc6ed56b5af1196f67c776bd80de9f2b9dc8bf84b0a8602a586fda43079  guix-build-c7fb80a08f98/output/powerpc64-linux-gnu/SHA256SUMS.part\n  e04410e453a9fcefacdbe9a1a43ad1f9ec6a36d622d258ea4208af1dc461692d  guix-build-c7fb80a08f98/output/powerpc64-linux-gnu/bitcoin-c7fb80a08f98-powerpc64-linux-gnu-debug.tar.gz\n  64135391e147c7357b17b72b1e54e93a9a7931f90c4d14a2066f1c9a160881a0  guix-build-c7fb80a08f98/output/powerpc64-linux-gnu/bitcoin-c7fb80a08f98-powerpc64-linux-gnu.tar.gz\n  3f2375042bc29a7f87cadc6ba3ce7389fa5e6f6c53b32836c7fc249e4ba9838e  guix-build-c7fb80a08f98/output/riscv64-linux-gnu/SHA256SUMS.part\n  33b8396ab0e1fd3121a85f1a80d81d52fe9be151f401f08283f9d5b8ecbd251b  guix-build-c7fb80a08f98/output/riscv64-linux-gnu/bitcoin-c7fb80a08f98-riscv64-linux-gnu-debug.tar.gz\n  418a264d0bcde9665d5760061284ca3b5533c9f63769a76bc64c69d8b3c7d82f  guix-build-c7fb80a08f98/output/riscv64-linux-gnu/bitcoin-c7fb80a08f98-riscv64-linux-gnu.tar.gz\n  3fed3e2d050059694da965e1752468c3d054f1acf5b774242eb8e7a73a775af5  guix-build-c7fb80a08f98/output/x86_64-apple-darwin/SHA256SUMS.part\n  a5d2ddf1c1bbc22d104ef08d0bd73f8d9c5c8404791df66d51ffc76a0c638fb2  guix-build-c7fb80a08f98/output/x86_64-apple-darwin/bitcoin-c7fb80a08f98-x86_64-apple-darwin-unsigned.tar.gz\n  bc3a44ca40c5bad631b76c240a7f1f46d0597cbf0c2389473d856e29775b3f1a  guix-build-c7fb80a08f98/output/x86_64-apple-darwin/bitcoin-c7fb80a08f98-x86_64-apple-darwin-unsigned.zip\n  5b2f0aaf4c023cda33fe952f18a977cc735c5e1524b45e734f99641ee605cc5d  guix-build-c7fb80a08f98/output/x86_64-apple-darwin/bitcoin-c7fb80a08f98-x86_64-apple-darwin.tar.gz\n  e56223d773f7d1a0a0dbe99d98e60420f729987f14fb98f18eabe6575352f68c  guix-build-c7fb80a08f98/output/x86_64-linux-gnu/SHA256SUMS.part\n  6e4a27fcafb1ec2dda41c7e486897ff51a4447d0ebfa6be30bdef6648c673786  guix-build-c7fb80a08f98/output/x86_64-linux-gnu/bitcoin-c7fb80a08f98-x86_64-linux-gnu-debug.tar.gz\n  3ff4232266a461bb55518a1e8834867e7e79c02914c59eb8f6b5052a26aefc12  guix-build-c7fb80a08f98/output/x86_64-linux-gnu/bitcoin-c7fb80a08f98-x86_64-linux-gnu.tar.gz\n  fd2cfb0befaf849e98574698ddab121a01c7894bb5acc789b9eb9c3bbe78e7b2  guix-build-c7fb80a08f98/output/x86_64-w64-mingw32/SHA256SUMS.part\n  58a2f67ecc94b2daad37ab99e74708c062094eb047136e57451d89f856d0c9aa  guix-build-c7fb80a08f98/output/x86_64-w64-mingw32/bitcoin-c7fb80a08f98-win64-debug.zip\n  6ccf68edc22dab4cc3171f3d8cdaed0444c438bca812512586edd81029de2c57  guix-build-c7fb80a08f98/output/x86_64-w64-mingw32/bitcoin-c7fb80a08f98-win64-setup-unsigned.exe\n  d466b5bc2ace63995ca22943997db7c292e240cdee7c63e127ecd380a1ca9558  guix-build-c7fb80a08f98/output/x86_64-w64-mingw32/bitcoin-c7fb80a08f98-win64-unsigned.tar.gz\n  b3fd8af55443feb8667940a18fb511e6d85ece1dd9fa0aa40f68e5ea86ab46df  guix-build-c7fb80a08f98/output/x86_64-w64-mingw32/bitcoin-c7fb80a08f98-win64.zip\n  ```\n\nACKs for top commit:\n  fanquake:\n    ACK c7fb80a08f9825d6d21d4a5545f42255fea11f62 - looks like this was last used in https://github.com/bitcoin/bitcoin/pull/27179.\n\nTree-SHA512: 40498cb514a31609e721b3865a99b91e4ff2bf5760750a42b5b16333d905d13cf2f87481aabc679c08b9e872a6886a7c928706b6d7ada08df02672d4b5156ba1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2465636318\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30653\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30653/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30653\">bitcoin/bitcoin#30653</a>: guix: Drop unused module from manifest"}},{"before":"8f761ea742e69b8e7878b601a0d2efb23c3fe323","after":"d08bedd81f184808c274f3c49cf5d581ccc78468","ref":"refs/heads/master","pushedAt":"2024-08-29T09:54:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30735: ci: Use C++23 in one task\n\nfac587ea070fe1354708aacce33ebb9cebd35e5b ci: Use C++23 once for testing (MarcoFalke)\nfa053ab7c01c03fada91ccfce885dd32e2e830ca build: Add Centos Stream 9 EOL URL (MarcoFalke)\n\nPull request description:\n\n  There are no plans to switch to C++23 anytime soon in the next couple of years. The only place right now that is known to benefit is `src/compat/byteswap.h`.\n\n  However, it is still useful to test with the option, because deprecated, removed or changed language features, as well as compiler changes that are guarded by the language version will be tested and developers can learn about them upfront.\n\n  Also includes a minor doc fixup commit.\n\nACKs for top commit:\n  davidgumberg:\n    ACK https://github.com/bitcoin/bitcoin/pull/30735/commits/fac587ea070fe1354708aacce33ebb9cebd35e5b\n  TheCharlatan:\n    ACK fac587ea070fe1354708aacce33ebb9cebd35e5b\n\nTree-SHA512: 1b81788eb5b4da77715d8b047279de65ae6b8920d5a21fd8cc94c3b0edb588ab8ffb7eaffb2f8b7806045de1d47ca85ca629f49038eca762f3136bf380cf3c87","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492070426\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30735\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30735/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30735\">bitcoin/bitcoin#30735</a>: ci: Use C++23 in one task"}},{"before":"00ad716c2b6a90ec8aeb54d5cebe93e86c371c0d","after":"8f761ea742e69b8e7878b601a0d2efb23c3fe323","ref":"refs/heads/master","pushedAt":"2024-08-29T09:53:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30739: doc: update dev note examples for CMake\n\n7de0c99804bca98ef159b7b778e6f5b602507d2c doc: update dev note examples for CMake (fanquake)\n\nPull request description:\n\n  Update the examples in the developer notes to work with CMake.\n  Also added an explicit `-DCMAKE_EXPORT_COMPILE_COMMANDS=ON` for clarity.\n\nACKs for top commit:\n  davidgumberg:\n    Tested ACK https://github.com/bitcoin/bitcoin/commit/7de0c99804bca98ef159b7b778e6f5b602507d2c\n  TheCharlatan:\n    ACK 7de0c99804bca98ef159b7b778e6f5b602507d2c\n  jonatack:\n    Tested ACK 7de0c99804bca98ef159b7b778e6f5b602507d2c on arm64 macOS 14.6.1\n\nTree-SHA512: 561fe5e777c5b29a4f26309700c03a730c5bbb2f838630abfaa4174112ced66e733c2109cb429a1927f1f3692bf1945f6386bcaffe604a76ea24633932d39171","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492229277\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30739\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30739/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30739\">bitcoin/bitcoin#30739</a>: doc: update dev note examples for CMake"}},{"before":"0e0de9484600f3a69ea4d87a3d2af0d8f3862af9","after":"00ad716c2b6a90ec8aeb54d5cebe93e86c371c0d","ref":"refs/heads/master","pushedAt":"2024-08-29T09:23:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30740: ci: Re-add configs removed in cmake migration\n\nfa80d39d82013b21a70677ac79bdff8c614379b7 ci: Re-add configs removed in cmake migration (MarcoFalke)\n\nPull request description:\n\n  In commit 9730288a0cd3f33021ef00fb2d95e5216d10ab61 many configs were removed from the CI without explanation.\n\n  Fix it by adding them back.\n\n  Can be reviewed by looking at:\n\n  * the parity table https://gist.github.com/hebasto/2ef97d3a726bfce08ded9df07f7dab5e\n  * the installed packages\n  * the CI logs from before the cmake migration and the CI logs of this pull request\n\nACKs for top commit:\n  fanquake:\n    ACK fa80d39d82013b21a70677ac79bdff8c614379b7\n\nTree-SHA512: a33335e117750e6c2e1490bb621f67c466f901793e43abe1bd0e263ef16fdcbc9e88be55c206167f3a5ddb39c1df6989c0fb7a96d9240243c000ba2e7f5e2747","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492340517\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30740\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30740/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30740\">bitcoin/bitcoin#30740</a>: ci: Re-add configs removed in cmake migr…"}},{"before":"4ae3be772d06c1b56a2b7b62540e523c35d50339","after":"0e0de9484600f3a69ea4d87a3d2af0d8f3862af9","ref":"refs/heads/master","pushedAt":"2024-08-29T08:36:39.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30700: doc: fix CI codespell warnings\n\n837fbca03602982d9f1055ac798711241ea3d0a0 Update spelling.ignore-words (Lőrinc)\nf9a08f35a537fd3a61a3898ff1f0b30d81e64afe doc: fix a few simple codespell warnings (Lőrinc)\n\nPull request description:\n\n  Can be checked locally by running `test/lint/lint-spelling.py`\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 837fbca03602982d9f1055ac798711241ea3d0a0\n  jonatack:\n    ACK 837fbca03602982d9f1055ac798711241ea3d0a0\n\nTree-SHA512: a83c78b9de4085749b916ffd255a9e72ffed06f09736ccff2dd4a4436d1fae7b22b1fb6073b0ce59ecb5bfdef4e43271494dadf3824647a42a4f26c26f092364","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2481685365\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30700\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30700/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30700\">bitcoin/bitcoin#30700</a>: doc: fix CI codespell warnings"}},{"before":"4ee1940e849efe8fb1510b11d78399231df4b578","after":"4ae3be772d06c1b56a2b7b62540e523c35d50339","ref":"refs/heads/master","pushedAt":"2024-08-29T08:33:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30744: doc: Fix typo in `build-unix.md`\n\ne78551baec1bd63192112a816cef8c207c049415 doc: Fix typo in `build-unix.md` (Hennadii Stepanov)\n\nPull request description:\n\n  Addresses https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1735220144.\n\nACKs for top commit:\n  davidgumberg:\n    ACK https://github.com/bitcoin/bitcoin/commit/e78551baec1bd63192112a816cef8c207c049415\n  l0rinc:\n    ACK e78551baec1bd63192112a816cef8c207c049415\n  tdb3:\n    ACK e78551baec1bd63192112a816cef8c207c049415\n\nTree-SHA512: a312a7718ac3fe4a9a204518f1306f4d4622b9c11e027f26960d15ac2e2380682604890a2ae4b874a28e0798f243f8226475cda3a8f468a1aa98df7ab26eea5f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492898157\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30744\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30744/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30744\">bitcoin/bitcoin#30744</a>: doc: Fix typo in <code>build-unix.md</code>"}},{"before":"d184fc3ba411ffb10117bc7b9ebf498233288218","after":"4ee1940e849efe8fb1510b11d78399231df4b578","ref":"refs/heads/master","pushedAt":"2024-08-28T16:33:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30734: doc: fix a few likely documentation typos related to CMake migration\n\n7ee5c3c5b2fb477a283df8861e28005ef514bd20 Fix a few likely documentation typos (Lőrinc)\n\nPull request description:\n\n  Found them during CMake migration - and ran a quick spellcheck for the rest to cover any remaining ones\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 7ee5c3c5b2fb477a283df8861e28005ef514bd20\n\nTree-SHA512: c6e7aa1e952e0d093745c4e6004c3907b7a215c6f998cc205307c0c68abcc067bf3f56e22af0deb1710186e8a871306f4bae8a35c74581e5299abcbbcddfaa75","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492048892\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30734\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30734/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30734\">bitcoin/bitcoin#30734</a>: doc: fix a few likely documentation typo…"}},{"before":"f93d5553d1e8525d24273be1179f60e39748618e","after":"d184fc3ba411ffb10117bc7b9ebf498233288218","ref":"refs/heads/master","pushedAt":"2024-08-28T15:56:38.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30571: test: [refactor] Use m_rng directly\n\n948238a683b6c99f4e91114aa75680c6c2d73714 test: Remove FastRandomContext global (Ryan Ofsky)\nfa0fe08eca48064b2a42789571fea017e455d820 scripted-diff: [test] Use g_rng/m_rng directly (MarcoFalke)\nfa54cab4734f02422f28fdffc0f11e6d3d51b8f0 test: refactor: Accept any RandomNumberGenerator in RandMoney (MarcoFalke)\n68f77dd21e4aaf4f09d36d6e5ddd7d260824b94b test: refactor: Pass rng parameters to test functions (Ryan Ofsky)\nfa19af555dff6d6c722caf36319b158699d2aa95 test: refactor: Move g_insecure_rand_ctx.Reseed out of the helper that calls MakeRandDeterministicDANGEROUS (MarcoFalke)\n3dc527f4602297ffcec3a578eadc480a620d01ec test: refactor: Give unit test functions access to test state (Ryan Ofsky)\nfab023e177d7eaef73902869ae1c95693f1e268b test: refactor: Make unsigned promotion explicit (MarcoFalke)\nfa2cb654eca8dd6ed89101cd6d199ba1de0b81e0 test: Add m_rng alias for the global random context (MarcoFalke)\nfae7e3791c9ed8053166773fcfb583ad19d006dd test: Correct the random seed log on a prevector test failure (MarcoFalke)\n\nPull request description:\n\n  This is mostly a style-cleanup for the tests' random generation:\n\n  1) `g_insecure_rand_ctx` in the tests is problematic, because the name is a leftover when the generator was indeed insecure. However, now the generator is *deterministic*, because the seed is either passed in or printed (c.f. RANDOM_CTX_SEED). Stating that deterministic randomness is insecure in the tests seems redundant at best. Fix it by just using `m_rng` for the name.\n\n  2) The global random context has many one-line aliases, such as `InsecureRand32`. This is problematic, because the same line of code may use the context directly and through a wrapper at the same time. For example in net_tests (see below). This inconsistency is harmless, but confusing. Fix it by just removing the one-line aliases.\n\n  ```\n  src/test/net_tests.cpp:        auto msg_data_1 = g_insecure_rand_ctx.randbytes<uint8_t>(InsecureRandRange(100000));\n  ````\n\n  3) The wrapper for randmoney has the same problem that the same unit test uses the context directly and through a wrapper at the same time. Also, it has a single type of Rng hardcoded. Fix it by accepting any type.\n\nACKs for top commit:\n  hodlinator:\n    ACK 948238a683b6c99f4e91114aa75680c6c2d73714\n  ryanofsky:\n    Code review ACK 948238a683b6c99f4e91114aa75680c6c2d73714. Only changes since last review were changing a comments a little bit.\n  marcofleon:\n    Code review ACK 948238a683b6c99f4e91114aa75680c6c2d73714. Only changes since my last review are the improvements in `prevector_tests`.\n\nTree-SHA512: 69c6b46a42cb743138ee8c87ff26a588dbe083e3efb3dca49b8a133ba5d3b09e8bf01c590ec7e121a7d77cb1fd7dcacd927a9ca139ac65e1f7c6d1ec46f93b57","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2444594558\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30571\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30571/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30571\">bitcoin/bitcoin#30571</a>: test: [refactor] Use m_rng directly"}},{"before":"f175a737c9e113c9df0f9e6c28d8fc379bffc620","after":"f93d5553d1e8525d24273be1179f60e39748618e","ref":"refs/heads/master","pushedAt":"2024-08-28T14:56:59.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string\n\na0abcbd3822bd17a1d73c42ccd5b040a150b0501 doc: Mention multipath specifier (Ava Chow)\n0019f61fc546b4d5f42eb4086f42560863fe0efb tests: Test importing of multipath descriptors (Ava Chow)\nf97d5c137d605ac48f1122a836c9aa5f834957ba wallet, rpc: Allow importdescriptors to import multipath descriptors (Ava Chow)\n32dcbca3fb918bc899a0637f876db31c3419aafd rpc: Allow importmulti to import multipath descriptors correctly (Ava Chow)\n64dfe3ce4bed9ac168d0b08def8af7485db94ef1 wallet: Move internal to be per key when importing (Ava Chow)\n16922455253f47fae0466c4ec6c3adfadcfe9182 tests: Multipath descriptors for scantxoutset and deriveaddresses (Ava Chow)\ncddc0ba9a9dca3ca5873d768b3b504cdb2ab947b rpc: Have deriveaddresses derive receiving and change (Ava Chow)\n360456cd221501fde3efe11bdba5c6d999dbb323 tests: Multipath descriptors for getdescriptorinfo (Ava Chow)\na90eee444c965bbd7bcddf9656eca9cee14c3aec tests: Add unit tests for multipath descriptors (Ava Chow)\n1bbf46e2dae4599d04c79aaacf7c5db00b2e707f descriptors: Change Parse to return vector of descriptors (Ava Chow)\n0d640c6f02bc20e5c1be773443dd74d8806d953b descriptors: Have ParseKeypath handle multipath specifiers (Ava Chow)\na5f39b103461a98689fd5d382e8da29037f55bea descriptors: Change ParseScript to return vector of descriptors (Ava Chow)\n0d55deae157f4f8226b2419d55e7dc0dfb6e4aec descriptors: Add DescriptorImpl::Clone (Ava Chow)\n7e86541f723d62c7ec6768f7f592c09ba2047d9e descriptors: Add PubkeyProvider::Clone (Ava Chow)\n\nPull request description:\n\n  It is convenient to have a descriptor which specifies both receiving and change addresses in a single string. However, as discussed in https://github.com/bitcoin/bitcoin/issues/17190#issuecomment-895515768, it is not feasible to use a generic multipath specification like BIP 88 due to combinatorial blow up and that it would result in unexpected descriptors.\n\n  To resolve that problem, this PR proposes a targeted solution which allows only a single pair of 2 derivation indexes to be inserted in the place of a single derivation index. So instead of two descriptor `wpkh(xpub.../0/0/*)` and `wpkh(xpub.../0/1/*)` to represent receive and change addresses, this could be written as `wpkh(xpub.../0/<0;1>/*)`. The multipath specifier is of the form `<NUM;NUM>`. Each `NUM` can have its own hardened specifier, e.g. `<0;1h>` is valid. The multipath specifier can also only appear in one path index in the derivation path.\n\n  This results in the parser returning two descriptors. The first descriptor uses the first `NUM` in all pairs present, and the second uses the second `NUM`. In our implementation, if a multipath descriptor is not provided, a pair is still returned, but the second element is just `nullptr`.\n\n  The wallet will not output the multipath descriptors (yet). Furthermore, when a multipath descriptor is imported, it is expanded to the two descriptors and each imported on its own, with the second descriptor being implicitly for internal (change) addresses. There is no change to how the wallet stores or outputs descriptors (yet).\n\n  Note that the path specifier is different from what was proposed. It uses angle brackets and the semicolon because these are unused characters available in the character set and I wanted to avoid conflicts with characters already in use in descriptors.\n\n  Closes #17190\n\nACKs for top commit:\n  darosior:\n    re-ACK a0abcbd3822bd17a1d73c42ccd5b040a150b0501\n  mjdietzx:\n    reACK a0abcbd3822bd17a1d73c42ccd5b040a150b0501\n  pythcoiner:\n    reACK a0abcbd\n  furszy:\n    Code review ACK a0abcbd\n  glozow:\n    light code review ACK a0abcbd3822\n\nTree-SHA512: 84ea40b3fd1b762194acd021cae018c2f09b98e595f5e87de5c832c265cfe8a6d0bc4dae25785392fa90db0f6301ddf9aea787980a29c74f81d04b711ac446c2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"983140832\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/22838\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/22838/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/22838\">bitcoin/bitcoin#22838</a>: descriptors: Be able to specify change a…"}},{"before":"0c90fc644395d1a3861a95dd46c6b1909af45784","after":"f175a737c9e113c9df0f9e6c28d8fc379bffc620","ref":"refs/heads/master","pushedAt":"2024-08-28T14:22:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30738: doc: fixup macOS build docs for CMake\n\n3c53e59dcf82d248427b4e329bfead0d2773cef3 doc: fixup macOS build docs for CMake (fanquake)\n\nPull request description:\n\n  Some minor corrections.\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 3c53e59dcf82d248427b4e329bfead0d2773cef3\n  TheCharlatan:\n    ACK 3c53e59dcf82d248427b4e329bfead0d2773cef3\n  hebasto:\n    ACK 3c53e59dcf82d248427b4e329bfead0d2773cef3.\n\nTree-SHA512: 431b4c88535fa3aaf2c7b452982f1ce47d82b84b667cbc2d926a2675c86e4b7e8ca9c9daecfa788668fc98c27db3c130531de62ac68edd94eab3ba2252cf4689","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492141921\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30738\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30738/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30738\">bitcoin/bitcoin#30738</a>: doc: fixup macOS build docs for CMake"}},{"before":"2eb358b25f628a88e3dd48811c0750a71befbead","after":"0c90fc644395d1a3861a95dd46c6b1909af45784","ref":"refs/heads/master","pushedAt":"2024-08-28T12:30:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30731: build: remove old MSVC build system\n\n04fb085f6bddc90e806deefd90c72104763f055a build: remove old MSVC build system (fanquake)\n\nPull request description:\n\n  This has been superseded by CMake, and should not be blocked on anything for removal.\n\nACKs for top commit:\n  laanwj:\n    ACK 04fb085f6bddc90e806deefd90c72104763f055a\n  hebasto:\n    ACK 04fb085f6bddc90e806deefd90c72104763f055a.\n  TheCharlatan:\n    ACK 04fb085f6bddc90e806deefd90c72104763f055a\n  vasild:\n    ACK 04fb085f6b, except:\n\nTree-SHA512: 219005bd0de1a9e37dabe45c979601df3083368f4c5ea224f70cf4e6f52e49d8f25713015ce005be3b34b56377eaafa339be7c50c63ce7f3ce7841ae55f3221f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2491795653\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30731\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30731/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30731\">bitcoin/bitcoin#30731</a>: build: remove old MSVC build system"}},{"before":"92c787f33de176c314af17590d37b927273c9d1c","after":"2eb358b25f628a88e3dd48811c0750a71befbead","ref":"refs/heads/master","pushedAt":"2024-08-28T11:18:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30508: depends: Fix CMake-generated `libzmq.pc` file\n\n371910a7682ecdaf86b3e65753667746add1ecd2 depends: Fix CMake-generated `libzmq.pc` file (Hennadii Stepanov)\n\nPull request description:\n\n  This is a backport of: https://github.com/zeromq/libzmq/pull/4706.\n\n  Similar to https://github.com/bitcoin/bitcoin/pull/30488.\n\n  Addresses https://github.com/bitcoin/bitcoin/pull/29723#issuecomment-2239864170:\n  > Looking at the mingw .pc generated by this PR:\n  >\n  > ```\n  > Libs: -L${libdir} -lzmq\n  > Libs.private:\n  > Requires.private:\n  > ```\n  >\n  > It looks like we'll need to take [zeromq/libzmq#4706](https://github.com/zeromq/libzmq/pull/4706) as well for CMake. That can be done as a follow-up though, as it's not yet merged upstream.\n\nACKs for top commit:\n  fanquake:\n    ACK 371910a7682ecdaf86b3e65753667746add1ecd2\n\nTree-SHA512: 6f9c2e32f83c0e629e32fd3e4c86712af00ffeaf0906bf85e5c2df889302707b9df102e8031249d1bae036eb4fc019c2a5124655682fbc5652d9337cb21c5f2c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2425281156\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30508\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30508/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30508\">bitcoin/bitcoin#30508</a>: depends: Fix CMake-generated <code>libzmq.pc</code>…"}},{"before":"e45913ea8b069c22ef247c47c3400bb757d77919","after":"92c787f33de176c314af17590d37b927273c9d1c","ref":"refs/heads/master","pushedAt":"2024-08-28T10:14:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30729: build: fix version number post CMake\n\n680f05ee98e4d7978e2c4f07fdbb8bc0d178c497 build: fix version number post CMake (fanquake)\n\nPull request description:\n\n  CMake was merged after branching-off for `28.x`.\n\nACKs for top commit:\n  hebasto:\n    ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497\n  TheCharlatan:\n    ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497\n  vasild:\n    ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497\n\nTree-SHA512: 18e10a49830b529f54f7c9ed81ff0489f9aac9779f34935ebe0051c742f3b7862ca5d3409a6d6347c2d9c6439dcdd1394333278308012fed473f5b00d80afdd5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2491651902\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30729\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30729/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30729\">bitcoin/bitcoin#30729</a>: build: fix version number post CMake"}},{"before":"338bc2cd261ba3daf7fb494f8cb4a534762e292c","after":"e45913ea8b069c22ef247c47c3400bb757d77919","ref":"refs/heads/master","pushedAt":"2024-08-28T10:14:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30712: fuzz: Add missing fuzz targets to cmake build\n\nfa0e1e4f3c2ede723554d10b6596d89955441373 fuzz: Add missing fuzz targets to cmake build (MarcoFalke)\n\nPull request description:\n\n  Fixes https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1726881676\n\n  Can be tested via:\n\n  ```\n  PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-autot/src/test/fuzz/fuzz > /tmp/f_autot\n  PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-cmake/src/test/fuzz/fuzz > /tmp/f_cmake\n  diff --unified /tmp/{f_autot,f_cmake}\n\nACKs for top commit:\n  hebasto:\n    ACK fa0e1e4f3c2ede723554d10b6596d89955441373\n\nTree-SHA512: 460ae650eae3c2b8936f48bff8c2b85cf3c2ccaf418109d1be9c5a32f9322bb500c7809cb3e81d5ffd24bf5e982ecedbbd7e04059ad60701f2ede9e3ba4a5804","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2485217858\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30712\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30712/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30712\">bitcoin/bitcoin#30712</a>: fuzz: Add missing fuzz targets to cmake …"}},{"before":"80f00cafdeef0600fa1a5e906686720786c2336c","after":"338bc2cd261ba3daf7fb494f8cb4a534762e292c","ref":"refs/heads/master","pushedAt":"2024-08-28T09:51:35.000Z","pushType":"push","commitsCount":69,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30454: build: Introduce CMake-based build system\n\n41051290ab3b6c36312cec26a27f787cea9961b4 cmake: Ignore build subdirectories within source directory (Hennadii Stepanov)\n6ce50fd9d0ae6850d54bf883e7a7c1bcb6912c5c doc: Update for CMake-based build system (Hennadii Stepanov)\n9730288a0cd3f33021ef00fb2d95e5216d10ab61 ci: Migrate CI scripts to CMake (Hennadii Stepanov)\nc360837ca5c91c9878ae8088bb5482e96fd87c96 cmake, lint: Adjust `lint_includes_build_config` (Hennadii Stepanov)\n3885441ee0d35a40904995ede68120fea471dde7 cmake: Add presets for native Windows builds (Hennadii Stepanov)\n7681746b20dd58e7d3e6d2852f07fb876383a133 cmake: Add vcpkg manifest file (Hennadii Stepanov)\n8b6f1c4353836bae6aa683cbc65251165bd031ba cmake: Add `Coverage` and `CoverageFuzz` scripts (Hennadii Stepanov)\n65bdbc1ff23b0a817f4d9a4682e6f630c9bbdd59 cmake: Add `docs` build target (Hennadii Stepanov)\nfb75ebbc33557ddd56f505100ad3631a0028eb86 cmake: Add compiler diagnostic flags (Hennadii Stepanov)\ne821f0a37a026fa0480c7f6f6c938da7c77e0d52 cmake: Migrate Guix build scripts to CMake (Hennadii Stepanov)\n747adb6ffe9b06d476fc5eaebbaf9a62b91a78c5 cmake: Add `Maintenance` module (Hennadii Stepanov)\n1f60b30df0cb58a7381a1bfbd6d34f002232e862 cmake: Add `APPEND_{CPP,C,CXX,LD}FLAGS` cache variables (Hennadii Stepanov)\n2b43c45b13ad00cfd9928a03da8a480977724cb1 cmake: Add `AddWindowsResources` module (Hennadii Stepanov)\n973a3b0c5dcbf6b3fd155b2dda4c2e94a0b0ee5f cmake: Implement `install` build target (Hennadii Stepanov)\n84ac35cfd4dfa6f235f6e5a00b571846358f45ce cmake: Add cross-compiling support (Hennadii Stepanov)\n0d01c228a7d39bb4918b5cb9f6db25cb8c30567a build: Generate `toolchain.cmake` in depends (Hennadii Stepanov)\n91a799247dc5e4627e6b2f221669c8ff9238bc8d depends: Add host-specific `cmake_system_version` variables (Hennadii Stepanov)\n9b31209b4caaa02b3044acd2375a7f595cdbd520 depends: Rename `cmake_system` -> `cmake_system_name` (Hennadii Stepanov)\n4a5208a81d5bfeef270c64d48dce3444d6d03511 Revert \"build, qt: Do not install *.prl files\" (Hennadii Stepanov)\n6522af62af1c3a6e2525bfffdb2295751b6fa49b depends: Amend handling flags environment variables (Hennadii Stepanov)\n90cec4d251a541adfc5953e24dc01840a8cb4af2 cmake: Add `MULTIPROCESS` option (Hennadii Stepanov)\nbb1a450dcb111746869547c8b538b5d2472cf8e6 cmake: Build `bitcoin-chainstate` executable (Hennadii Stepanov)\naed38ea58cbde068fe12b5299b246b4e3649a09c cmake: Build `bitcoinkernel` library (Hennadii Stepanov)\n975d67369b8f3a33a21fd7618c299c0ec138292c cmake: Build `test_bitcoin-qt` executable (Hennadii Stepanov)\n10fcc668a3430b72eaf7effc83f00cedeb27c7dc cmake: Add `WITH_DBUS` option (Hennadii Stepanov)\n5bb5a4bc75a523e30eab561763927252ce105c4d cmake: Add `libqrencode` optional package support (Hennadii Stepanov)\n57a6e2ef4abbfd2b12ee6489366bc6609bead263 cmake: Build `bitcoin-qt` executable (Hennadii Stepanov)\n30f642952cb5bf39479bdbe467b3950f0d09324a cmake: Add `WERROR` option (Hennadii Stepanov)\nc98d4a4c341e524348d0342e145d439816a44c83 cmake: Add `REDUCE_EXPORTS` option (Hennadii Stepanov)\na01cb6e63ff3940f0773b37e2fe1e148f17acad9 cmake: Add `HARDENING` option (Hennadii Stepanov)\na8a2e364acf55bbe18404ab21f852d52257bcb6d cmake: Add Python-based tests (Hennadii Stepanov)\n3d853795707c5a1828dcd09c1f68bb07dee472cd cmake: Add fuzzing options (Hennadii Stepanov)\n908530e312a3d4561f9c1feeb2a76ce899f21c68 cmake: Add `SANITIZERS` option (Hennadii Stepanov)\n8bb0e85631e7c1bee16e136454b2466776be1d65 cmake: Build `bench_bitcoin` executable (Hennadii Stepanov)\n801735163a81650619a6c9587e8f1df9ee182694 cmake: Add external signer support (Hennadii Stepanov)\n353e0c9e9679864a777e17c1bb7c6ba8b6eac96d cmake: Add `systemtap-sdt` optional package support (Hennadii Stepanov)\nd2fda82b4954f4af7e7d340cf42b9cb34d96cde1 cmake: Add `libzmq` optional package support (Hennadii Stepanov)\nae7b39a0e106d798b6e9cc03ee783d9081e41480 cmake: Add `libminiupnpc` optional package support (Hennadii Stepanov)\n6480e1dcdb03f43ce3d0aad96b8668d017d11750 cmake: Add `libnatpmp` optional package support (Hennadii Stepanov)\ne73e9304a11af65f9b086460ff349f9f700709ce cmake: Build `bitcoin-util` executable (Hennadii Stepanov)\n027c6d7caa0355c35b00f2689eddccc3d1227aef cmake: Build `bitcoin-tx` executable (Hennadii Stepanov)\nd10c5c34c3d899db8bcff47ac8c6ba396a6da4b6 cmake: Add wallet functionality (Hennadii Stepanov)\nab2e99b0d95714e16a7d1a1313d7da938b0485cb cmake: Create test suite for `ctest` (Hennadii Stepanov)\n959370bd76d30ced34208db45fb4fd097fbad31b cmake: Build `test_bitcoin` executable (Hennadii Stepanov)\nb27bf9700dbbfa9a0243815f78c8b62abe78d8bc cmake: Build `bitcoin-cli` executable (Hennadii Stepanov)\na9813df826c885b1609e55a83d87cd9cbc90adfd cmake: Build `bitcoind` executable (Hennadii Stepanov)\n97829ce2d5a8dc3b0307b5d57c6686b96b7cf850 cmake: Add `FindLibevent` module (Hennadii Stepanov)\n3118e40c6157c8ab9e264518d1065d2b0fc07795 cmake: Build `bitcoin_consensus` library (Hennadii Stepanov)\n809a2f192903145f88f30bc10d3cf1ab9ed06881 cmake: Build `bitcoin_util` static library (Hennadii Stepanov)\n0a9a521a704ca8a27124c1498a86e87ad46d4c34 cmake: Build `bitcoin_crypto` library (Hennadii Stepanov)\n958971f476a29cb5bb76f3ae80ae968317ca1930 cmake: Build `univalue` static library (Hennadii Stepanov)\n752747fda801f2c0ecce91c96bcc9ef93e27462b cmake: Generate `obj/build.h` header (Hennadii Stepanov)\n1f0a78edf3cd2c24236ac512acf420eb9ed86ab3 cmake: Build `minisketch` static library (Hennadii Stepanov)\n12bfbc81540f037c95e7796ae0b9f05ce3fb1b4a cmake: Build `leveldb` static library (Hennadii Stepanov)\n51985c5304dfc52bd45f505b3115989637d79ff5 cmake: Build `crc32c` static library (Hennadii Stepanov)\ndb7a198f29c62c5f762eaa25d1d83c57e2f1e211 cmake: Build `secp256k1` subtree (Hennadii Stepanov)\ndbb7ed14e8562439238eec70b202c50f172e3def cmake: Add `ccache` support (Hennadii Stepanov)\ncedfdf6c72535d0797a271c6bb9d84c4b406a8ea cmake: Redefine/adjust per-configuration flags (Hennadii Stepanov)\nb6b5e732c8b49a2cc14f34ac72b2189389c6b27d cmake: Add global compiler and linker flags (Hennadii Stepanov)\nf98327931bd0b5d90678ddd1770e9862266b396e cmake: Add `TryAppendLinkerFlag` module (Hennadii Stepanov)\n4a0af29697b62d32af6f60d3ec70cd2ed4d7243c cmake: Add `TryAppendCXXFlags` module (Hennadii Stepanov)\n35cffc497d8db3cf3eee35c1513e3435558f056b cmake: Add POSIX threads support (Hennadii Stepanov)\nfd72d00ffe34c84e292b305f6797201040d31a72 cmake: Add position independent code support (Hennadii Stepanov)\n07069e2bb0bbdacf16cf34efd3a33390de030217 cmake: Add introspection module (Hennadii Stepanov)\n27d687fc1f6aceaed7725e1e904a093ead68d6e6 cmake: Add `config/bitcoin-config.h` support (Hennadii Stepanov)\nfe5cdace5ffba46fb7981efb816621962d3873e3 cmake: Print compiler and linker flags in summary (Hennadii Stepanov)\n70683884c5fd78dbf7816434464e6511b9d4e486 cmake: Introduce interface libraries to encapsulate common flags (Hennadii Stepanov)\na2317e27b7fb86df4e32cd1674c06e09cb808248 cmake: Add root `CMakeLists.txt` file (Hennadii Stepanov)\n\nPull request description:\n\n  This PR introduces a new CMake-based build system, which is a drop-in replacement for the current Autotools-based build system.\n\n  ML announcement: https://groups.google.com/g/bitcoindev/c/hgKkfQWzrTo\n\n  As discussed during the recent CoreDev meetup in April, the switch from Autotools to CMake is intended to happen as soon as possible after branching 28.x off, which means that 29.0 will be built using CMake.\n\n  This PR branch is essentially the [staging branch](https://github.com/hebasto/bitcoin/tree/cmake-staging), with every change reviewed and tested by a group of contributors, including (in alphabetical order):\n  - [**achow101**](https://github.com/achow101)\n  - [**fanquake**](https://github.com/fanquake)\n  - [**maflcko**](https://github.com/maflcko)\n  - [**m3dwards**](https://github.com/m3dwards)\n  - [**pablomartin4btc**](https://github.com/pablomartin4btc)\n  - [**real-or-random**](https://github.com/real-or-random)\n  - [**ryanofsky**](https://github.com/ryanofsky)\n  - [**sipsorcery**](https://github.com/sipsorcery)\n  - [**TheCharlatan**](https://github.com/TheCharlatan)\n  - [**theStack**](https://github.com/theStack)\n  - [**theuni**](https://github.com/theuni)\n  - [**vasild**](https://github.com/vasild)\n\n  Reviewing in a separate staging repo was suggested in https://github.com/bitcoin/bitcoin/pull/27060#issuecomment-1431798320.\n\n  The accompanying changes to the OSS-Fuzz project are available in https://github.com/hebasto/oss-fuzz/pull/8.\n\n  Please refer to the [build options parity table](https://gist.github.com/hebasto/2ef97d3a726bfce08ded9df07f7dab5e). The \"auto\" value is no longer available; non-default values must be specified explicitly. Additionally, the new default values have been chosen to suit the everyday build experience for the majority of developers.\n\n  System requirements for using the CMake-based build system:\n  - CMake >= 3.22 (if not available in your system's repository, it can be downloaded from https://cmake.org/download/)\n  - a build tool of your choice:\n  - any Make (GNU Make is no longer a requirement); GNU Make is still required to build depends\n  - Ninja (https://ninja-build.org/)\n  - MSBuild\n  - Xcode\n\n  A note for Windows users: The default installation of the latest version of MSVC 17.10.4 includes both CMake 3.28.3 and the vcpkg package manager).\n\n  ---\n\n  We, the build system developers, kindly ask reviewers to refrain from making suggestions that are not directly related to the migration process or can be implemented separately. Bugs in the scripts and errors in the updated documentation should be the focus of this PR. Please be advised that comments not aligned with this PR's goal may be ignored.\n\n  Thank you all for your understanding.\n\nACKs for top commit:\n  maflcko:\n    review ACK 41051290ab3b6c36312cec26a27f787cea9961b4 🐥\n  sipsorcery:\n    ACK 41051290ab3b6c36312cec26a27f787cea9961b4.\n  vasild:\n    ACK 41051290ab3b6c36312cec26a27f787cea9961b4\n  TheCharlatan:\n    ACK 41051290ab3b6c36312cec26a27f787cea9961b4\n  pablomartin4btc:\n    tACK 41051290ab3b6c36312cec26a27f787cea9961b4\n  i-am-yuvi:\n    tACK [`4105129`](https://github.com/bitcoin/bitcoin/commit/41051290ab3b6c36312cec26a27f787cea9961b4)\n  theuni:\n    ACK 41051290ab3b6c36312cec26a27f787cea9961b4.\n  fanquake:\n    ACK 41051290ab3b6c36312cec26a27f787cea9961b4\n\nTree-SHA512: 6c1445054436c6c00ad63bfa0f19d64091a2b25c9bd694f85bf2218ac358ffb774d6c000685b3ca1e9b50401babed989fa2a0694b774c211d226bfd1944c9b39","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2411379174\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30454\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30454/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30454\">bitcoin/bitcoin#30454</a>: build: Introduce CMake-based build system"}},{"before":"128ade02e44547de22942a5fcc4f2d23b9ce777f","after":"80f00cafdeef0600fa1a5e906686720786c2336c","ref":"refs/heads/master","pushedAt":"2024-08-28T09:34:52.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29071: refactor: Remove Span operator==, Use std::ranges::equal\n\nfad0cf6f2619df8df435a2da6da49eeb5510a10f refactor: Use std::ranges::equal in GetNetworkForMagic (MarcoFalke)\nfadf0a7e15d66ba3230153e789b785e6cf8ab84c refactor: Remove Span operator==, Use std::ranges::equal (MarcoFalke)\n\nPull request description:\n\n  `std::span` removed the comparison operators, so it makes sense to remove them for the `Span` \"backport\" as well. Using `std::ranges::equal` also has the benefit that some `Span` temporary constructions can now be dropped.\n\n  This is required to move from `Span` toward `std::span`.\n\nACKs for top commit:\n  hodlinator:\n    Untested Code Review re-ACK fad0cf6\n  stickies-v:\n    ACK fad0cf6f2619df8df435a2da6da49eeb5510a10f\n  TheCharlatan:\n    ACK fad0cf6f2619df8df435a2da6da49eeb5510a10f\n\nTree-SHA512: 5b9d1826ceac2aabae2295bc89893dd23ac3a1cc0d41988331cdbdc21be531aa91795d5273819f349f79648c6c4f30ed31af6e7a3816153e92080061b92ffe00","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2039458902\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29071\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29071/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29071\">bitcoin/bitcoin#29071</a>: refactor: Remove Span operator==, Use st…"}},{"before":"f4a10911c70eb5a603d073c499326ccd8a645963","after":"128ade02e44547de22942a5fcc4f2d23b9ce777f","ref":"refs/heads/master","pushedAt":"2024-08-28T08:42:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30725: fuzz: fix timeout in `crypto_fschacha20poly1305`\n\n8dec4e1294a6c6895b4fe23f38cd067dc8f2352f fuzz: fix timeout in `crypto_fschacha20poly1305` (brunoerg)\n\nPull request description:\n\n  Fixes #30505\n\n  This PR fixes a timeout in `crypto_fschacha20poly1305` by reducing the number of iterations. I left it running for a while and noticed it speeds up the target and do not impact coverage.\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 8dec4e1294a6c6895b4fe23f38cd067dc8f2352f\n  stratospher:\n    ACK 8dec4e1. saw similar coverage stats (these are from different machines, saw more similar from same machine).\n\nTree-SHA512: 66cd689f10f09cf880c1f2c77aa481336a95a7e10b655d156b2dc9cd38165670000019a6fb3775485ccb5cce248939a52a31ebd755a6befed6274cc841d21d97","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2489583396\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30725\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30725/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30725\">bitcoin/bitcoin#30725</a>: fuzz: fix timeout in `crypto_fschacha20p…"}},{"before":"2c7a4231db35060fa1ab66d29e8139f04edc85a4","after":"f4a10911c70eb5a603d073c499326ccd8a645963","ref":"refs/heads/master","pushedAt":"2024-08-28T08:42:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30721: refactor: Testnet4 - Replace uint256S(\"str\") -> uint256{\"str\"}\n\n49f9b645ea3f42c1b9e0a83b26af8fc8f6fa159d refactor: Testnet4 - Replace uint256S(\"str\") -> uint256{\"str\"} (Hodlinator)\n\nPull request description:\n\n  Ran scripted-diff from 2d9d752e4fc30aabf2ddd36ca7a63432d26d4fea:\n  ```\n  sed -i --regexp-extended -e 's/\\buint256S\\(\"(0x)?([^\"]{64})\"\\)/uint256{\"\\2\"}/g' $(git grep -l uint256S)\n  ```\n\n  Follow-up to Testnet4 introduction #29775 which overlapped with work on `uint256` `consteval` ctor #30560 (the latter includes the scripted-diff commit).\n\n  Going forward `uint256{}` should be used for constants instead of `uint256S()`.\n\nACKs for top commit:\n  maflcko:\n    review-ACK 49f9b645ea3f42c1b9e0a83b26af8fc8f6fa159d 🐮\n  fjahr:\n    ACK 49f9b645ea3f42c1b9e0a83b26af8fc8f6fa159d\n\nTree-SHA512: 94fe5d9f1fb85e9ce5c3c4c5e4c31667e8cbb55ee691a4b5b3ae4172ccac38230281071023663965917f188b4c19bdf67afd4e3cdf69d89e97c65faea88af833","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2488765114\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30721\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30721/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30721\">bitcoin/bitcoin#30721</a>: refactor: Testnet4 - Replace uint256S(\"s…"}},{"before":"99b06b7f1d4194fb8036b90e5308101645f968e7","after":"2c7a4231db35060fa1ab66d29e8139f04edc85a4","ref":"refs/heads/master","pushedAt":"2024-08-27T20:48:03.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30569: node: reduce unsafe uint256S usage\n\n18d65d27726bf9fc7629b8e794047a10c9cf6156 test: use uint256::FromUserHex for RANDOM_CTX_SEED (stickies-v)\n6819e5a329c3bf38e47a07434e2a3c0031f808d0 node: use uint256::FromUserHex for -assumevalid parsing (stickies-v)\n2e58fdb544b538dba9823bcd5754d074272bfc04 util: remove unused IsHexNumber (stickies-v)\n8a44d7d3c1e5d5af6779c3e4befe514c9dafb8ff node: use uint256::FromUserHex for -minimumchainwork parsing (stickies-v)\n70e2c87737e77ee85812cc328c4ddfaea7147533 refactor: add uint256::FromUserHex helper (stickies-v)\n85b7cbfcbe3f94770bdf73dedd8bda0193a44627 test: unittest chainstatemanager_args (stickies-v)\n\nPull request description:\n\n  Since fad2991ba073de0bd1f12e42bf0fbaca4a265508, `uint256S` has been [deprecated](https://github.com/bitcoin/bitcoin/pull/30482/commits/fad2991ba073de0bd1f12e42bf0fbaca4a265508#diff-800776e2dda39116e889839f69409571a5d397de048a141da7e4003bc099e3e2R138) because it is less robust than the `base_blob::FromHex()` introduced in [the same PR](https://github.com/bitcoin/bitcoin/pull/30482). Specifically, it tries to recover from length-mismatches, recover from untrimmed whitespace, 0x-prefix and garbage at the end, instead of simply requiring exactly 64 hex-only characters. _(see also #30532)_\n\n  This PR carves out the few `uint256S` callsites that may potentially prove a bit more controversial to change because they deal with user input and backwards incompatible behaviour change.\n\n  The main behaviour change introduced in this PR is:\n  - `-minimumchainwork` will raise an error when input is longer than 64 hex digits\n  - `-assumevalid` will raise an error when input contains invalid hex characters, or when it is longer than 64 hex digits\n  - test: the optional RANDOM_CTX_SEED env var will now cause tests to abort when it contains invalid hex characters, or when it is longer than 64 hex digits\n\n  After this PR, the remaining work to remove `uint256S` completely is almost entirely mechanical and/or test related. I will open that PR once #30560 is merged because it builds on that.\n\nACKs for top commit:\n  hodlinator:\n    re-ACK 18d65d27726bf9fc7629b8e794047a10c9cf6156\n  l0rinc:\n    ACK 18d65d27726bf9fc7629b8e794047a10c9cf6156\n  achow101:\n    ACK 18d65d27726bf9fc7629b8e794047a10c9cf6156\n  ryanofsky:\n    Code review ACK 18d65d27726bf9fc7629b8e794047a10c9cf6156. Very nice change that cleans up the API, adds checking for invalid values, makes parsing of values more consistent, and adds test coverage.\n\nTree-SHA512: ec118ea3d56e1dfbc4c79acdbfc797f65c4d2107b0ca9577c848b4ab9b7cb8d05db9f3c7fe8441a09291aca41bf671572431f4eddc59be8fb53abbea76bbbf86","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2443189383\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30569\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30569/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30569\">bitcoin/bitcoin#30569</a>: node: reduce unsafe uint256S usage"}},{"before":"dc90542a9e964011aa6c87e5246233b4559c865b","after":"99b06b7f1d4194fb8036b90e5308101645f968e7","ref":"refs/heads/master","pushedAt":"2024-08-27T18:10:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29369: refactor: Allow CScript construction from any std::input_iterator\n\nfa7b9b99a2ed466d1765d748f4a59c2f581b974f refactor: Require std::input_iterator for all InputIterator in prevector (MarcoFalke)\nd4444419001ca2af4c601a996461b67110645a52 refactor: Allow CScript construction from any std::input_iterator (MarcoFalke)\n\nPull request description:\n\n  Currently only (pre)vector iterators and raw pointers are accepted. However, this makes it harder to construct from input iterators provided by other classes, such as `std::span`.\n\n  Fix that.\n\nACKs for top commit:\n  delta1:\n    reACK fa7b9b9\n  achow101:\n    ACK fa7b9b99a2ed466d1765d748f4a59c2f581b974f\n  hodlinator:\n    ACK fa7b9b99a2ed466d1765d748f4a59c2f581b974f\n  ryanofsky:\n    Code review ACK fa7b9b99a2ed466d1765d748f4a59c2f581b974f\n\nTree-SHA512: 2760861f8bce42fb27dc0825e61621cb157f1ac3619a0834df38eb8319b6dcf9de43d90397a4c160f43340880c1553df638848e9057a27c792214331243ef4a5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2114598281\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29369\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29369/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29369\">bitcoin/bitcoin#29369</a>: refactor: Allow CScript construction fro…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEqb7nDAA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin-core/gui"}