Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Typo? #717

Open
andreasgriffin opened this issue Dec 21, 2023 · 1 comment · May be fixed by #751
Open

Documentation: Typo? #717

andreasgriffin opened this issue Dec 21, 2023 · 1 comment · May be fixed by #751

Comments

@andreasgriffin
Copy link

Hi
in https://github.com/bitcoin-core/HWI/blob/7fd2cead481197f88cad180757b5cf982eb0a0b1/hwilib/common.py#L41C1-L42
there is P2WPSH. But should it not be P2WSH as defined in https://github.com/bitcoin/bips/blob/master/bip-0048.mediawiki ?
@brunoerg
Copy link
Contributor

I think so. P2WSH/P2SH-P2WSH for scripts.

@brunoerg brunoerg linked a pull request Aug 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typo on type of address brunoerg/HWI
2 participants
@brunoerg @andreasgriffin