{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":100066342,"defaultBranch":"master","name":"HWI","ownerLogin":"bitcoin-core","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-08-11T20:02:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13464320?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712422657.0","currentOid":""},"activityList":{"items":[{"before":"ef39080b8b1c8d01997ab5badb836d387c500b7f","after":"3322cab95a84ddb2129a8b239d34a054339febe4","ref":"refs/heads/master","pushedAt":"2024-08-30T17:08:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#749: docs: update it to use CMake for Bitcoin Core\n\na41fe6f605c442e5cb8ab2d92b53e904e5075ca8 docs: update it to use CMake for Bitcoin Core (Bruno Garcia)\n\nPull request description:\n\nACKs for top commit:\n  achow101:\n    ACK a41fe6f605c442e5cb8ab2d92b53e904e5075ca8\n\nTree-SHA512: deba536235216b08e28f50198df8c8bff710d9567d68ec30d49bdc2240862b831c61f2cab4f5f476b8c682954d55ef187153e4f75c47154d900b10c7d62c00b0","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2497385334\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/749\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/749/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/749\">#749</a>: docs: update it to use CMake for Bitcoin Core"}},{"before":"fd19fa796bcf8c5d282a44c8ab13dff34645f70d","after":"ef39080b8b1c8d01997ab5badb836d387c500b7f","ref":"refs/heads/master","pushedAt":"2024-08-30T17:06:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#743: ci: Always run test\n\nedab2afc5a7538ebec884520b5ae99fefb0a19f9 ci: Always run test (Ava Chow)\n\nPull request description:\n\n  Always run test jobs even if sim-builder fails as some sims should always build and we should run the tests for those.\n\nTop commit has no ACKs.\n\nTree-SHA512: c6602f3418037b77e4f79cb534f10cea920a84d58ea7f596c5b950467f9e0d0367bd11c77362824fc4c9a2b4f37db7a4fa2a3c222eaa22154d38e3acbbb39ae6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2384210542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/743\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/743/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/743\">#743</a>: ci: Always run test"}},{"before":"4f0c0477c6f66270b20818306ce7730c92952b48","after":"fd19fa796bcf8c5d282a44c8ab13dff34645f70d","ref":"refs/heads/master","pushedAt":"2024-08-29T16:02:50.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#742: trezor: add Trezor Safe 5 support\n\n3f91b357dc98c26636fc45a5f57353c09ae49775 build: make sure Trezors are built with gcc 12 (matejcik)\n5f32310271d1346a4ba4e7187549357af8d60d38 trezor: add Trezor Safe 5 and Trezor Safe 3 rev2 support (matejcik)\n\nPull request description:\n\n  just updated definitions from upstream trezorlib\n\nACKs for top commit:\n  achow101:\n    ACK 3f91b357dc98c26636fc45a5f57353c09ae49775\n\nTree-SHA512: 94e235832082ca3920e9e53d2925d8b32863526fe97cd1d4958b38b237309f4872daad803d5ea998113fd211aeb8d31f5139574926cdeb342db7e34b643e9afc","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2383865012\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/742\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/742/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/742\">#742</a>: trezor: add Trezor Safe 5 support"}},{"before":"9fbe6beb63d9a3be68aec084fd9ac0bef4756119","after":"4f0c0477c6f66270b20818306ce7730c92952b48","ref":"refs/heads/master","pushedAt":"2024-08-29T16:01:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#746: Update Ledger udev rules and model IDs\n\nb6e0d334c7240c45f2cb13dfde0f3b18d11e12d3 Add model ids for Ledger Stax and Ledger Flex (Salvatore Ingala)\n9d05f425cfe2ec63ef3aa925191c1f7e0faf8b4b Update the udev rules for Ledger devices (Salvatore Ingala)\n\nPull request description:\n\n  Updated as per https://github.com/LedgerHQ/udev-rules/blob/f474382e370c9fa2a2207e6e675b9b364441aed7/20-hw1.rules, with more generic rules and including support for Ledger Stax and Flex.\n\n  Also added the corresponding device IDs for `hwi enumerate`.\n\nACKs for top commit:\n  achow101:\n    ACK b6e0d334c7240c45f2cb13dfde0f3b18d11e12d3\n\nTree-SHA512: 2badab5a9608d51904211937389beac3111b3e09eb13e547ef4ffd9cd4d6cd7fe9dc771a8b300dcfe9626658cd4ddbf516ce00e7d2d201dc95b50e5427b68ba6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2408100610\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/746\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/746/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/746\">#746</a>: Update Ledger udev rules and model IDs"}},{"before":"1a129afb91a52edf0978c4c4c5dd4137f3893d82","after":"9fbe6beb63d9a3be68aec084fd9ac0bef4756119","ref":"refs/heads/master","pushedAt":"2024-06-24T21:00:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#735: test/test_device: do not enforce a password\n\n7fef64e7cf67490f5e0e97cd9aa62b8edd325c74 test/test_device: do not enforce a password (Marko Bencun)\n\nPull request description:\n\n  According to the type in `HardwareWalletClient`, password is optional and can be `None`:\n\n  ```\n  def __init__(self, path: str, password: Optional[str], expert: bool, chain: Chain = Chain.MAIN) -> None:\n  ```\n\n  The test code also expects that it can be `None`, e.g.:\n\n  https://github.com/bitcoin-core/HWI/blob/d774d65255e1e78ea4d97846c2b4d26a23febcfb/test/test_device.py#L140\n\n  The BitBox02 client in fact checks that it must be `None` and raises a `BadArgumentError` otherwise, as the BitBox02 does not accept any password/passphrase from the host:\n\n  https://github.com/bitcoin-core/HWI/blob/d774d65255e1e78ea4d97846c2b4d26a23febcfb/hwilib/devices/bitbox02.py#L266\n\n  Other devices like the Jade also don't take a host password/passphrase, and simply ignore the param. We could also do this for the BitBox02 (not raise any error if a password is supplied), but the right solution is to not enforce a password in the tests.\n\n  This commit is in preparation of adding a BitBox02 simulator with tests.\n\nACKs for top commit:\n  achow101:\n    ACK 7fef64e7cf67490f5e0e97cd9aa62b8edd325c74\n\nTree-SHA512: 6a32fa347706c6bc4f74a534a77369d8e85a7cdb75042155d04d7c18647278e78ad2c2bf1cfd4936529dbd6aea6aa236001acedefe608cdf39cbae90a08c8068","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2261204264\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/735\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/735/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/735\">#735</a>: test/test_device: do not enforce a password"}},{"before":"39dd18ca7fb160464fedbc4bb5069bbbdd86626b","after":"1a129afb91a52edf0978c4c4c5dd4137f3893d82","ref":"refs/heads/master","pushedAt":"2024-06-24T20:59:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#739: descriptor.py: fix parsing tr() desc with single leaf TREE\n\n4e8559b1b8ff07ae4eb8177a3a5e2ba3d8367014 descriptor.py: fix parsing tr() desc with single leaf TREE (SomberNight)\n\nPull request description:\n\n  `tr()` descriptors with a single leaf TREE expression cannot be parsed currently:\n  ```py\n  >>> from hwilib.descriptor import parse_descriptor\n  >>> b = parse_descriptor(\"tr(a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd,pk(669b8afcec803a0d323e9a17f3ea8e68e8abe5a278020a929adbec52421adbd0))\")\n  Traceback (most recent call last):\n    File \"/home/user/wspace/HWI/hwilib/descriptor.py\", line 437, in _get_func_expr\n      end = s.rindex(\")\")\n  ValueError: substring not found\n\n  During handling of the above exception, another exception occurred:\n\n  Traceback (most recent call last):\n    File \"<stdin>\", line 1, in <module>\n    File \"/home/user/wspace/HWI/hwilib/descriptor.py\", line 637, in parse_descriptor\n      return _parse_descriptor(desc, _ParseDescriptorContext.TOP)\n    File \"/home/user/wspace/HWI/hwilib/descriptor.py\", line 600, in _parse_descriptor\n      subscripts.append(_parse_descriptor(sarg, _ParseDescriptorContext.P2TR))\n    File \"/home/user/wspace/HWI/hwilib/descriptor.py\", line 527, in _parse_descriptor\n      func, expr = _get_func_expr(desc)\n    File \"/home/user/wspace/HWI/hwilib/descriptor.py\", line 440, in _get_func_expr\n      raise ValueError(\"A matching pair of parentheses cannot be found\")\n  ValueError: A matching pair of parentheses cannot be found\n  ```\n\nACKs for top commit:\n  achow101:\n    ACK 4e8559b1b8ff07ae4eb8177a3a5e2ba3d8367014\n\nTree-SHA512: cafc92d4c95b89dc209522a735f37edbc4f91c9abe62668d28c97306e36cf48d1c6d059ead1788462ddf657e0eb9e594d3478cb6f0e170f79b1928fc04523dd2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315784717\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/739\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/739/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/739\">#739</a>: descriptor.py: fix parsing tr() desc with single leaf TREE"}},{"before":"d774d65255e1e78ea4d97846c2b4d26a23febcfb","after":"39dd18ca7fb160464fedbc4bb5069bbbdd86626b","ref":"refs/heads/master","pushedAt":"2024-06-24T20:29:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#733: build: Use debian buster for releases\n\n2fe0c4271d89d418fcd76f59749d90b0aeca85f0 build: Use debian buster for releases (Ava Chow)\n\nPull request description:\n\n  Fixes #732\n\nTop commit has no ACKs.\n\nTree-SHA512: 48760ef99898769b4d148c09989923a3207e26d29a06ee47145693f67c4788a9ff584a615677290b05414c58f8ce1104f7f9238323a42ddbcb71a57a327bfefd","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2248942443\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/733\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/733/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/733\">#733</a>: build: Use debian buster for releases"}},{"before":"766d0d09d4f977ed5f2749ebfb4c2c8fff160a41","after":"d774d65255e1e78ea4d97846c2b4d26a23febcfb","ref":"refs/heads/master","pushedAt":"2024-04-06T16:57:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Bump to 3.0.0 and regenerate setup.py","shortMessageHtmlLink":"Bump to 3.0.0 and regenerate setup.py"}},{"before":"b5786addc314dd1c0edcfedd62111b73c1abdb2f","after":"766d0d09d4f977ed5f2749ebfb4c2c8fff160a41","ref":"refs/heads/master","pushedAt":"2024-04-01T21:02:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Bump to 3.0.0-rc.1 and regenerate setup.py","shortMessageHtmlLink":"Bump to 3.0.0-rc.1 and regenerate setup.py"}},{"before":"cfaf26c6a21a898221f9dc54a5e9bb133e57116f","after":"b5786addc314dd1c0edcfedd62111b73c1abdb2f","ref":"refs/heads/master","pushedAt":"2024-04-01T21:00:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#729: Add --emulators option to explicitly choose to detect emulators in enumeration and device auto detection\n\nea7310f59058a1e685186f2070dc68201cb82470 Bump version to 3.0.0 (Ava Chow)\n27c1b4272a137af1dfd6f4fd12db2cc9143e0b16 Add --emulators option and skip enumerating emulators by default (Ava Chow)\n\nPull request description:\n\n  This changes the default behavior to ignore emulators unless specified with `--emulators`. Since this is a backwards incompatible change, the major version number is bumped to 3.\n\n  Closes #653\n\nTop commit has no ACKs.\n\nTree-SHA512: 373dbf21e813471c58262cd8e27f1c33f63d42db783ff0f567d223b5e35589e116f3c1029c13befddb741555da41940f97bafd443fc135ad0de0b7e7086749f7","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2209503455\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/729\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/729/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/729\">#729</a>: Add --emulators option to explicitly choose to detect emu…"}},{"before":"8d4fa19551ce1b097bd011ce1e7ce64008a1d87c","after":"cfaf26c6a21a898221f9dc54a5e9bb133e57116f","ref":"refs/heads/master","pushedAt":"2024-03-29T16:36:20.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#724: Fix builds, update build containers, update dependencies, and fix ci.\n\ned0b4e0495ff302b89734ec48517926b1de5df34 test, ledger: Update automation for new message display (Ava Chow)\n4eca419bf8c555c4121d6c0661b841774b502c87 ci: Set test timeout of 45 minutes (Ava Chow)\ne4f51bca67ee11c6faf49ce0afd5c05930df8352 test, trezor: Install rustfmt component (Ava Chow)\n4e4a4e70ea664de36c3976cb3c9bdb255f2aaaab ci: Bump action versions to avoid deprecation warnings (Ava Chow)\n21f7e11a02918d950cca9f82ce0bd8f9710b5911 ci: Ignore flake8 E231 (Ava Chow)\ncb570be9e0c06a061b47ae4604137ed1bdb5c0d5 trezor: Fix lint error (Ava Chow)\n2d64407afd9f3325f57a765ff10222c1cfca3ad0 ledger: Add missing type annotation (Ava Chow)\nc2366dba556d4bd8c4a9b6b9d55c98d03703cf0f scripted-diff: Use assertEqual instead of assertEquals (Ava Chow)\n9a38436c78787c0601b9639fe8a345cbd15e2dd4 keepky: Update TrezorModel to include internal_name (Ava Chow)\n0b50184b0049f8e6d31bca21d6a2916ed95a256a deps: Update dependencies (Ava Chow)\n9d43b37ba75b33cee4bb859555a7340931dce278 build: Update build containers to debian bookworm (Ava Chow)\na71a82081ed21d8f7a8541bb0755a50c453ad877 build: Fix arch check for hwi-qt moving (Ava Chow)\n\nPull request description:\n\n  Couple of minor things that weren't fully working while doing the 2.4.0 build.\n\n  Also periodic update to dependencies.\n\nTop commit has no ACKs.\n\nTree-SHA512: 397f7d2284a1f4cbb45f6fff3008161a1f5a5e1fd10c0572c02e4811a42dc1a9f6acbd55259ca9b8f0672da1e21cb9f8f0fc3187b093d50f0e6cc8611a54ff06","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2109117479\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/724\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/724/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/724\">#724</a>: Fix builds, update build containers, update dependencies,…"}},{"before":"ac1a323d175674f99d23388d5b0f59a4d4b016b6","after":"8d4fa19551ce1b097bd011ce1e7ce64008a1d87c","ref":"refs/heads/master","pushedAt":"2024-01-30T18:32:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Bump to 2.4.0 and regenerate setup.py","shortMessageHtmlLink":"Bump to 2.4.0 and regenerate setup.py"}},{"before":"5a1beafabce43503410a1f4a485d6894ee584566","after":"ac1a323d175674f99d23388d5b0f59a4d4b016b6","ref":"refs/heads/master","pushedAt":"2024-01-30T18:30:35.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#615: Build for `arm64` on `amd64`\n\n3d3c02d30949b378101446cb6f8ca57a7665ff00 Improve (Kiminuo)\nee3cf5f4655cf2dbd270453d0b865717a3088dfa Add release instructions (Kiminuo)\nd93c8f7ab0886e030ff8f30aaf99d86ab95cd687 Add support for arm64 (Kiminuo)\n\nPull request description:\n\n  Related to https://github.com/bitcoin-core/HWI/issues/345\n  Related to https://github.com/zkSNACKs/WalletWasabi/issues/4051#issuecomment-743071851\n  Discussion: Some discussion here: https://github.com/kiminuo/HWI/pull/1\n\n  This PR just shows how to do a deterministic build for `arm64` architecture. The hope is HWI's support for `arm64` will improve a bit.\n\n  ### Setup\n\n  To set up your environment, install:\n\n  ```s\n  sudo apt install qemu-user-static\n  ```\n\n  ### Build for arm64\n\n  Use [docker buildx](https://docs.docker.com/buildx/working-with-buildx/) to replicate [deterministic build instructions](https://github.com/bitcoin-core/HWI/blob/master/docs/development/release-process.rst#deterministic-builds-with-docker) for the arm64 build:\n\n  ```s\n  docker buildx build --no-cache --platform linux/arm64 -t hwi-builder -f contrib/build.Dockerfile .\n\n  # Note the use of \"--without-gui\".\n  docker run --platform linux/arm64 -it --rm --name hwi-builder -v $PWD:/opt/hwi  --workdir /opt/hwi hwi-builder /bin/bash -c \"contrib/build_bin.sh --without-gui && contrib/build_dist.sh --without-gui\"\n  ```\n\n  i.e. the change is:\n\n  ```diff\n  -docker build --no-cache -t hwi-builder -f contrib/build.Dockerfile .\n  -docker run -it --name hwi-builder -v $PWD:/opt/hwi --rm  --workdir /opt/hwi hwi-builder /bin/bash -c \"contrib/build_bin.sh && contrib/build_dist.sh && contrib/build_wine.sh\"\n  +docker buildx build --no-cache --platform linux/arm64 -t hwi-builder -f contrib/build.Dockerfile .\n  +docker run --platform linux/arm64 -it --rm --name hwi-builder -v $PWD:/opt/hwi  --workdir /opt/hwi hwi-builder /bin/bash -c \"contrib/build_bin.sh --without-gui && contrib/build_dist.sh --without-gui\"\n  ```\n\n  ### Resources\n\n  * https://docs.docker.com/build/building/multi-platform/#building-multi-platform-images\n  * https://medium.com/@artur.klauser/building-multi-architecture-docker-images-with-buildx-27d80f7e2408\n\n  ## Limitations\n\n  ### No GUI support\n\n  So far I had no luck with building `hwi-qt` because I get the following error\n\n  ```\n  Installing dependencies from lock file\n\n  Package operations: 14 installs, 0 updates, 0 removals\n\n    • Installing shiboken2 (5.15.2): Failed\n\n    RuntimeError\n\n    Unable to find installation candidates for shiboken2 (5.15.2)\n\n    at ~/.pyenv/versions/3.9.7/lib/python3.9/site-packages/poetry/installation/chooser.py:72 in choose_for\n         68│\n         69│             links.append(link)\n         70│\n         71│         if not links:\n      →  72│             raise RuntimeError(\n         73│                 \"Unable to find installation candidates for {}\".format(package)\n         74│             )\n         75│\n         76│         # Get the best link\n  ```\n\n  during execution of [`poetry install -E qt`](https://github.com/kiminuo/HWI/blob/a025af3ee3fdf0bac8dbdbc51b9e82ab946660b4/contrib/build_bin.sh#L12)\n\n  That's why I use `build_bin.sh --without-gui` (see #655)\n\nACKs for top commit:\n  achow101:\n    ACK 3d3c02d30949b378101446cb6f8ca57a7665ff00\n\nTree-SHA512: 3df877ec3da07997c8281722ea0ec4687d850f1fec33cb5664e3f03cd8854cb02a90ce799da2123a88058b681fbb2bad31bdacbb485474d19fa88b60a4b73d83","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1273323105\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/615\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/615/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/615\">#615</a>: Build for <code>arm64</code> on <code>amd64</code>"}},{"before":"975211d2b02ef0e5ca505b9cc31e0e6c2d1af7cc","after":"5a1beafabce43503410a1f4a485d6894ee584566","ref":"refs/heads/master","pushedAt":"2024-01-18T18:53:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Bump to 2.4.0-rc.1 and regenerate setup.py","shortMessageHtmlLink":"Bump to 2.4.0-rc.1 and regenerate setup.py"}},{"before":"bc6b053f507aed731aaf25e93348075ff4db8e06","after":"975211d2b02ef0e5ca505b9cc31e0e6c2d1af7cc","ref":"refs/heads/master","pushedAt":"2024-01-17T19:43:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#719: gui: add chain in the title\n\n7f4aca10ba56349ff5927cf43ddaade3147b1581 gui: add chain in the title (Bruno Garcia)\n\nPull request description:\n\n  It allows to identify the chain (main, test, etc)\n  when using the GUI.\n\nACKs for top commit:\n  achow101:\n    ACK 7f4aca10ba56349ff5927cf43ddaade3147b1581\n\nTree-SHA512: 69d218c20d84444dc3b81a9b9dad4c058644b1f493028a2baca7b167efa5951563c6addef024e9c39f196ccd53ca22c2e187aa97d836d27c87c49384f6a8600f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2056674545\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/719\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/719/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/719\">#719</a>: gui: add chain in the title"}},{"before":"953d3dc84033909227ad6510710c77297e984730","after":"bc6b053f507aed731aaf25e93348075ff4db8e06","ref":"refs/heads/master","pushedAt":"2024-01-17T19:42:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#721: ci: Update readthedocs config\n\nd10dbe8b3a8b112cc4bc18c446dd03cd6bb0a8a7 ci: Update readthedocs config (Ava Chow)\n\nPull request description:\n\n  Read The Docs has added a few new required config options.\n\nTop commit has no ACKs.\n\nTree-SHA512: 97bbbe1e3aabfab245aa7db014b0df18eba73ff390f04f6772c72585cab6531fb986e5d63b89f64ebfda37575caca4475308c1e31eda3937f830c809e4f4e682","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2086817288\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/721\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/721/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/721\">#721</a>: ci: Update readthedocs config"}},{"before":"e8174155d99dadcdd0d110217ac299f459c9090b","after":"953d3dc84033909227ad6510710c77297e984730","ref":"refs/heads/master","pushedAt":"2024-01-17T19:11:25.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#619: Improve instructions for the testing environment\n\nadf0fe2253cc38d083638d77168ad83c4d439803 Add coldcard instructions (Giacomo Caironi)\nfa5f38922274f2449162c34d74f92a1ab8e79450 Add instructions for building the ledger emulator (Giacomo Caironi)\n\nPull request description:\n\n  Instructions to build the testing environment are not exhaustive. This PR tries to fix this\n\nACKs for top commit:\n  achow101:\n    ACK adf0fe2253cc38d083638d77168ad83c4d439803\n\nTree-SHA512: af43e56b510a836446a15085838475747cb5e4c1813ad59aee3bfaee9ddebeb2706d3d8f5d848f96e4efc480d35c4a99423595c26699e3b3816db456a3f42880","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1294137819\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/619\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/619/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/619\">#619</a>: Improve instructions for the testing environment"}},{"before":"59eeb858b1c28a75266d915546a8353328ba3369","after":"e8174155d99dadcdd0d110217ac299f459c9090b","ref":"refs/heads/master","pushedAt":"2024-01-17T19:02:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#715: add support for Python 3.12\n\nb1912994f365696064a002b68d498d2b2d82ee62 add support for Python 3.12 (Filip Gospodinov)\n\nPull request description:\n\n  Fedora 39 ships with Python 3.12. To achieve a better out-of-the-box experience, support for Python 3.12 is added. This required `pyinstaller` and `hidapi` to be updated.\n\n  `pyinstaller` has dropped support for Python 3.7 because it reached EOL on on 2023-06-27 [1]. The `pyinstaller` update forces us to also drop support for Python 3.7. Considering that HWI is a security-sensitive package it makes sense to stop using EOL software components.\n\n  ~~`hidapi` is missing a release that works with Python 3.12 [2] so we depend on a git version for now.~~\n  `hidapi` is missing a release that works on Alpine Linux [2] but this is an orthogonal issue.\n\n  [1] https://github.com/pyinstaller/pyinstaller/commit/da33dbf1681afa7541124034a8aa40227353dcf2\n  [2] https://github.com/trezor/cython-hidapi/issues/168\n\nACKs for top commit:\n  achow101:\n    ACK b1912994f365696064a002b68d498d2b2d82ee62\n\nTree-SHA512: d3d5d9212af873bbd03d57dfe7b911af342f26eca3d4dddc12ed218f5e9f05c13ce23ea74495bc8d897e2db0ad3ccbcd772ca785be57ec395218fc9d43ded0bb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2037762483\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/715\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/715/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/715\">#715</a>: add support for Python 3.12"}},{"before":"73b7661aa748b4387c13dd50f974f12574291fd7","after":"59eeb858b1c28a75266d915546a8353328ba3369","ref":"refs/heads/master","pushedAt":"2024-01-17T18:55:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#718: Improve error handle for `Ledger` devices\n\n0d5412a7ea6a2f4043d2bccfd4e0957caffba65f Improve error handle for `Ledger` devices (Bruno Garcia)\n\nPull request description:\n\n  Discovered it while reviewing [#bitcoin/24313](https://github.com/bitcoin/bitcoin/pull/24313). The `ledger_exception` function was not dealing with `ApduException` exceptions. It's basically similar to `BTChipException` and we can use its \"error code\" to return friendly error messages.\n\n  e.g for `displayaddress`:\n\n  **before**:\n  `{\"error\": \"Exception: invalid status 0x6985\", \"code\": -13}`\n  **after**:\n  `{\"error\": \"display_singlesig_address canceled\", \"code\": -14}`\n\nACKs for top commit:\n  achow101:\n    ACK 0d5412a7ea6a2f4043d2bccfd4e0957caffba65f\n\nTree-SHA512: f4dbe57e5f41c67a19ce6e9c0f4b4af8184ff360cfc3709f4fb15f55014906c0a6c04a869a9315083aac18175dd8b921c022d18826d3e1f31d4bdb4a736b6171","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2056618221\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/718\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/718/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/718\">#718</a>: Improve error handle for <code>Ledger</code> devices"}},{"before":"d800783b438564d7cd3e197b9e7b74825e4b5a1a","after":"73b7661aa748b4387c13dd50f974f12574291fd7","ref":"refs/heads/master","pushedAt":"2024-01-17T18:53:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#714: fix typos\n\n43c7c6417cf96bc9a78f9f9526d9c1c107f53b10 fix typos (omahs)\n\nPull request description:\n\n  fix typos\n\nACKs for top commit:\n  achow101:\n    ACK 43c7c6417cf96bc9a78f9f9526d9c1c107f53b10\n\nTree-SHA512: 22ecc596146b0147c11a042ce72aa5d99b97d627b8528ddd2eaa304ee15e493f44e77c9239e444757cd5256acd8933940b976866749c04db884cae0a6d02adf5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2027880128\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/714\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/714/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/714\">#714</a>: fix typos"}},{"before":"7fd2cead481197f88cad180757b5cf982eb0a0b1","after":"d800783b438564d7cd3e197b9e7b74825e4b5a1a","ref":"refs/heads/master","pushedAt":"2024-01-17T18:52:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#716: fix(trezor): enable support for Trezor Safe 3\n\n43745141ffa4ac6eeff17492775f5a696e93022b fix(trezor): enable support for Trezor Safe 3 (matejcik)\n\nPull request description:\n\n  fixes #713\n\nACKs for top commit:\n  achow101:\n    ACK 43745141ffa4ac6eeff17492775f5a696e93022b\n\nTree-SHA512: 696d506db99b1df981c3cb94f607d1b7b6beb0465080557d0ae0df5683799667c3bfb36642c16b06084bb24ea14a747e892253ef77df93fba75a9cc856f607ce","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2048936868\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/716\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/716/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/716\">#716</a>: fix(trezor): enable support for Trezor Safe 3"}},{"before":"26862f8e1b84ca497f96084ab3210054fb5dc0cf","after":"7fd2cead481197f88cad180757b5cf982eb0a0b1","ref":"refs/heads/master","pushedAt":"2023-11-14T21:49:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#712: fix typo in coldcard simulador doc\n\n1b3ec54887481c9c74f7004b41ae66aec241ea2b fix typo in coldcard simulador doc (Bruno Garcia)\n\nPull request description:\n\nACKs for top commit:\n  achow101:\n    ACK 1b3ec54887481c9c74f7004b41ae66aec241ea2b\n\nTree-SHA512: 7469d273d26dc21b03c2b5e9dae35b25ea22eec6a6b1a40def383617c9f1b68533cf3cefb396f744e408a7fb0508c48aee7dca4234ed82ced4c10abfa4e82290","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1966216830\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/712\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/712/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/712\">#712</a>: fix typo in coldcard simulador doc"}},{"before":"2b600cd99b45e4985963aee957dd3c24e34905c7","after":"26862f8e1b84ca497f96084ab3210054fb5dc0cf","ref":"refs/heads/master","pushedAt":"2023-11-14T21:48:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#711: improve error message when parentheses cannot be found in descriptor\n\ndab0c11af4a788d7144e55af9bdc5af9ab607211 improve error message when parentheses cannot be found in descriptor (Bruno Garcia)\n\nPull request description:\n\nACKs for top commit:\n  achow101:\n    ACK dab0c11af4a788d7144e55af9bdc5af9ab607211\n\nTree-SHA512: d2cccb0998507262161cbd5aecf357fb83d809d099b5e4ff6d459d64a92c378e0cf48554a7a9390f59810135b86a6cf9065c5c6fd99d62b1a46bf04e2710d116","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1964398018\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/711\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/711/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/711\">#711</a>: improve error message when parentheses cannot be found in…"}},{"before":"e77a339181a46e7303e60245827e8744ca8b4ca1","after":"2b600cd99b45e4985963aee957dd3c24e34905c7","ref":"refs/heads/master","pushedAt":"2023-11-14T21:48:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#696: use warning instead of deprecated warn\n\nb49c14e81494174f59712c5235228d37e0267584 use warning instead of deprecated warn (fametrano)\n\nPull request description:\n\n  logging.warn has been deprecated since Python 3.3 and one should use logging.warning\n\n  see also https://github.com/Blockstream/Jade/pull/77\n\nACKs for top commit:\n  achow101:\n    ACK b49c14e81494174f59712c5235228d37e0267584\n\nTree-SHA512: f766b1049be3808c6d3f94ac8b72975b84272297c62c8c2fd65bf4d7c3dad940190b275e053ff233a112779ad59aa7dc08d709711cb5a956c3396e87ea62b784","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1833751921\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/696\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/696/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/696\">#696</a>: use warning instead of deprecated warn"}},{"before":"70ffb2be827e5b3d304203b4ded1f79c07b04a5f","after":"e77a339181a46e7303e60245827e8744ca8b4ca1","ref":"refs/heads/master","pushedAt":"2023-11-14T21:41:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#710: Update jade api\n\n0f2bbdca3a444bc4b559a9a452dd66e0cc79ffa6 jade: update Jade api to 1.0.24 (Jamie C. Driver)\n\nPull request description:\n\n  Update jade api to latest version.\n  Updates cbor dependency as requested in https://github.com/bitcoin-core/HWI/issues/678\n  Includes fametrano changes to py api logging.\n\nACKs for top commit:\n  achow101:\n    ACK 0f2bbdca3a444bc4b559a9a452dd66e0cc79ffa6\n\nTree-SHA512: fc8f0b302bacc85457df23c75b5d7f64ecb4ad062481098a7d3bd62f859593151ef2cd99107310a752d4edeb2e4fb85c984d24a7b5163d7ee8073c656b8a7447","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1961202062\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/710\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/710/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/710\">#710</a>: Update jade api"}},{"before":"c3a94b6f9d696b3a669153dcda2bfdad9c80583e","after":"70ffb2be827e5b3d304203b4ded1f79c07b04a5f","ref":"refs/heads/master","pushedAt":"2023-09-15T17:04:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#707: ci: Replace Cirrus CI with GitHub Actions\n\nbdb79f6803147468a3a5d34e29f600eb9d633d97 ci: Replace Cirrus CI with GitHub Actions (Hennadii Stepanov)\n\nPull request description:\n\n  This PR moves tests from Cirrus CI, which [is not free anymore](https://cirrus-ci.org/blog/2023/07/17/limiting-free-usage-of-cirrus-ci/), to GitHub Actions.\n\n  Possible performance improvements (caching, etc.) are left for future follow-ups.\n\nACKs for top commit:\n  achow101:\n    ACK bdb79f6803147468a3a5d34e29f600eb9d633d97\n\nTree-SHA512: b51d2f2f83c6f0cd79cf2d9703892e79c9446dad4c07177d91079fa347394884444f141f2d5874a8263f95e1af635eb42c700a7cabfdda99bf6eb9a986e14372","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1886157039\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/707\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/707/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/707\">#707</a>: ci: Replace Cirrus CI with GitHub Actions"}},{"before":"0462cfcbc5201a6beb8c3d87219d21159f61d985","after":"c3a94b6f9d696b3a669153dcda2bfdad9c80583e","ref":"refs/heads/master","pushedAt":"2023-08-16T21:42:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Bump version to 2.3.1 and regenerate setup.py","shortMessageHtmlLink":"Bump version to 2.3.1 and regenerate setup.py"}},{"before":"5242d85c07ef99f4710f76234d638a6957c47a13","after":"0462cfcbc5201a6beb8c3d87219d21159f61d985","ref":"refs/heads/master","pushedAt":"2023-08-16T21:29:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#697: nest loggers in the proper way\n\n75af80b0695f9b08c6df356a6548c627b3c8eb9b present naming preference (without trailing .log) (fametrano)\n324b88e099cb2ec7c0d82ceb11c4c3175695567a nest loggers in the proper way (fametrano)\n\nPull request description:\n\n  see also:\n\n  - https://github.com/Blockstream/Jade/pull/78\n  - https://github.com/LedgerHQ/ledgercomm/pull/16\n  - https://github.com/trezor/trezor-firmware/pull/3190\n\nACKs for top commit:\n  achow101:\n    ACK 75af80b0695f9b08c6df356a6548c627b3c8eb9b\n\nTree-SHA512: 2044b39680e2683fa0a25d9f50f66f8b204fc0b5685c032caef3ccd36cc255e10ce1676902e82a75d4fc7cacb5ea7b5de51a6839f46de4cc64a5010adf76c712","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1833828029\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/697\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/697/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/697\">#697</a>: nest loggers in the proper way"}},{"before":"315a75b1f0fc08fc13308fe8b73846e417d3b941","after":"5242d85c07ef99f4710f76234d638a6957c47a13","ref":"refs/heads/master","pushedAt":"2023-08-16T21:27:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#698: do not initialize Decimal from float\n\n2692f7fa32d9acf6df917c97ec066b7a44333af4 do not initialize Decimal from float (Ferdinando M. Ametrano)\n\nPull request description:\n\n  this avoid warnings and prefer explicit proper initialization\n\n  See https://github.com/LedgerHQ/app-bitcoin-new/pull/191\n\nACKs for top commit:\n  achow101:\n    ACK 2692f7fa32d9acf6df917c97ec066b7a44333af4\n\nTree-SHA512: deba1b3b654e89f4b61911b45199b782a961abff9e62496a500852dda0f917bf541e6fd58c17baca6289fe708b94ba7e47b95821ba1479cc9cdbdbb4d38128f9","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1833922840\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/698\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/698/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/698\">#698</a>: do not initialize Decimal from float"}},{"before":"17d5643b9db240d4fbee3f1614e7e1aeade4e9ac","after":"315a75b1f0fc08fc13308fe8b73846e417d3b941","ref":"refs/heads/master","pushedAt":"2023-08-16T21:25:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/HWI#701: fix base58.decode_check()\n\nc31eed944b742f8145d985c9d11535ee41e06532 fix base58.decode_check() (Marko Bencun)\n\nPull request description:\n\n  The function used the full sha256 and not just the first four bytes to verify the checksum. As a result, the checksum check always fails.\n\n  This breaks the BitBox02 multisig registration, which uses this function to decode xpubs. This broke when it switched to using the internal base58 library over the `base58` dependency in 674cb08d6ffcecbf2502a05dd4371c1cfc8baa93.\n\n  Fixes #700.\n\nACKs for top commit:\n  achow101:\n    ACK c31eed944b742f8145d985c9d11535ee41e06532\n\nTree-SHA512: 5a4687c38cc8cdaac4c284aa422b485f607d4f8b3d123c982bd4bb713ddfb5971b45c2de2357368494cf83b29b04401f0f4b740acf08adfd24b5ca78e86e02c7","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1841176030\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/HWI/issues/701\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/HWI/pull/701/hovercard\" href=\"https://github.com/bitcoin-core/HWI/pull/701\">#701</a>: fix base58.decode_check()"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEqOLCbAA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin-core/HWI"}