Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAPI 1.5: update registrations for TRAPI KPs used #817

Open
colleenXu opened this issue May 2, 2024 · 6 comments
Open

TRAPI 1.5: update registrations for TRAPI KPs used #817

colleenXu opened this issue May 2, 2024 · 6 comments
Labels
bug Something isn't working On Test Related changes are deployed to Test server

Comments

@colleenXu
Copy link
Collaborator

colleenXu commented May 2, 2024

@tokebe

I think dev/CI need updating to use the TRAPI 1.5 registrations of TRAPI KPs. I noticed today that my local instance in "CI" mode retrieves the TRAPI 1.4 Test instances of the TRAPI KPs during the smartapi_sync.

Basically all the TRAPI KPs now have their Dev/CI instances in new TRAPI 1.5 registrations, which we can see in the "SmartAPI Info" tab of the ARAX-UI. (Connections Hypothesis Provider only has their dev instance, but I think we can basically ignore that for now. We won't be able to use this registration in CI)

I'm making a PR to address this. Can you see if any other places in the code need adjusting?
I think it works okay (I used it when testing Pathfinder earlier).

As for BTE's Test instance....I think we'd have to wait until the TRAPI 1.5 KP registrations advertise the Test instances. Then we may need to ask for a deployment so BTE Test can use those registrations...

@colleenXu colleenXu added the bug Something isn't working label May 2, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented May 2, 2024

@tokebe I noticed another part of the code where 1.4 shows up and I couldn't tell if it was a TRAPI 1.4 thing that needed adjustment or not. If it needs adjusting, maybe it can be added to this issue/the PR?

@tokebe
Copy link
Member

tokebe commented May 2, 2024

Added a commit to the PR for that, thanks for catching it.

@colleenXu colleenXu added the On CI Related changes are deployed to CI server label May 2, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented May 3, 2024

We aren't using the TRAPI 1.5 registration for CHP (only has the dev instance on it). We'll wait until later when CI/Test instances are added to the registration, and then request patches to Test when needed.

For all the other TRAPI KPs, we've updated to use their TRAPI 1.5 registrations (dev/CI instances included right now, should add Test instances right after the coordinated-deployment to Test is done).

@colleenXu colleenXu added On CI -> Test and removed On CI Related changes are deployed to CI server labels May 3, 2024
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI -> Test labels May 9, 2024
@colleenXu
Copy link
Collaborator Author

Update:
In Dev/CI, we are now using the TRAPI 1.5 registration for CHP. It has dev/CI instances.

We're not in a hurry to patch this to Test, because the registration currently doesn't have test instances. BTE Test would therefore skip/not use this tool...

@colleenXu
Copy link
Collaborator Author

The TRAPI 1.5 registration for CHP now has the Test instance (ARAX-UI view).

Screen Shot 2024-05-28 at 5 26 32 PM

@colleenXu colleenXu added On CI Related changes are deployed to CI server and removed On Test Related changes are deployed to Test server labels Jun 14, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented Jun 14, 2024

To make clear...

@colleenXu colleenXu added On Test Related changes are deployed to Test server and removed On CI Related changes are deployed to CI server labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working On Test Related changes are deployed to Test server
Projects
None yet
Development

No branches or pull requests

2 participants