-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRAPI 1.5: update registrations for TRAPI KPs used #817
Comments
@tokebe I noticed another part of the code where 1.4 shows up and I couldn't tell if it was a TRAPI 1.4 thing that needed adjustment or not. If it needs adjusting, maybe it can be added to this issue/the PR? |
Added a commit to the PR for that, thanks for catching it. |
We aren't using the TRAPI 1.5 registration for CHP (only has the dev instance on it). We'll wait until later when CI/Test instances are added to the registration, and then request patches to Test when needed. For all the other TRAPI KPs, we've updated to use their TRAPI 1.5 registrations (dev/CI instances included right now, should add Test instances right after the coordinated-deployment to Test is done). |
Update: We're not in a hurry to patch this to Test, because the registration currently doesn't have test instances. BTE Test would therefore skip/not use this tool... |
The TRAPI 1.5 registration for CHP now has the Test instance (ARAX-UI view). |
To make clear...
|
@tokebe
I think dev/CI need updating to use the TRAPI 1.5 registrations of TRAPI KPs. I noticed today that my local instance in "CI" mode retrieves the TRAPI 1.4 Test instances of the TRAPI KPs during the smartapi_sync.
Basically all the TRAPI KPs now have their Dev/CI instances in new TRAPI 1.5 registrations, which we can see in the "SmartAPI Info" tab of the ARAX-UI. (Connections Hypothesis Provider only has their dev instance, but I think we can basically ignore that for now. We won't be able to use this registration in CI)
I'm making a PR to address this. Can you see if any other places in the code need adjusting?
I think it works okay (I used it when testing Pathfinder earlier).
As for BTE's Test instance....I think we'd have to wait until the TRAPI 1.5 KP registrations advertise the Test instances. Then we may need to ask for a deployment so BTE Test can use those registrations...
The text was updated successfully, but these errors were encountered: