Changed log level of Capturer Object #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexPatrie
requested review from
fbergmann and
eagmon
and removed request for
fbergmann
eagmon
approved these changes
May 7, 2023
|
Working on a generalization now! |
|
Kudos, SonarCloud Quality Gate passed!
|
This was
linked to
issues
May 8, 2023
|
seems that the try: except: block to catch an assertion is unexpected - is there a reason that an if or if/else could not have been used? Generally using try/except for normal flow of control is not best practice in most languages. If this is in response to SonarCloud - then we need to address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pr do?
Addresses an issue related to this specific repo and others, as per #56.
The
log_levelin method is by default set toStandardOutputErrorCapturerLevel.cwhich is"c". This results in a lack of proper output and a capture freeze. when setting thislog_levelto.python, a perfect output is produced in a timely fashion.