💅 noUnusedImports still removes comments above the imports

[fregante]

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.14.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "bun/1.1.32"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 false

Linter:
  JavaScript enabled:           true
  JSON enabled:                 true
  CSS enabled:                  true
  GraphQL enabled:              false
  Recommended:                  false
  All:                          false
  Enabled rules:
  style/useNodejsImportProtocol
  correctness/noUnusedImports
  style/useExportType
  style/useImportType

Workspace:
  Open Documents:               0

Rule name

noUnusedImports

Playground link

https://biomejs.dev/playground/?lintRules=all&analyzerFixMode=safeAndUnsafeFixes&code=LwAqAAoAIAAqACAAVABoAGkAcwAgAHAAcgBvAGcAcgBhAG0AIABpAHMAIABmAHIAZQBlACAAcwBvAGYAdAB3AGEAcgBlADoAIAB5AG8AdQAgAGMAYQBuACAAcgBlAGQAaQBzAHQAcgBpAGIAdQB0AGUAIABpAHQAIABhAG4AZAAvAG8AcgAgAG0AbwBkAGkAZgB5AAoAIAAqACAAaQB0ACAAdQBuAGQAZQByACAAdABoAGUAIAB0AGUAcgBtAHMAIABvAGYAIAB0AGgAZQAgAEcATgBVACAAQQBmAGYAZQByAG8AIABHAGUAbgBlAHIAYQBsACAAUAB1AGIAbABpAGMAIABMAGkAYwBlAG4AcwBlACAAYQBzACAAcAB1AGIAbABpAHMAaABlAGQAIABiAHkACgAgACoAIAB0AGgAZQAgAEYAcgBlAGUAIABTAG8AZgB0AHcAYQByAGUAIABGAG8AdQBuAGQAYQB0AGkAbwBuACwAIABlAGkAdABoAGUAcgAgAHYAZQByAHMAaQBvAG4AIAAzACAAbwBmACAAdABoAGUAIABMAGkAYwBlAG4AcwBlACwAIABvAHIACgAgACoAIAAoAGEAdAAgAHkAbwB1AHIAIABvAHAAdABpAG8AbgApACAAYQBuAHkAIABsAGEAdABlAHIAIAB2AGUAcgBzAGkAbwBuAC4ACgAgACoACgAgACoAIABUAGgAaQBzACAAcAByAG8AZwByAGEAbQAgAGkAcwAgAGQAaQBzAHQAcgBpAGIAdQB0AGUAZAAgAGkAbgAgAHQAaABlACAAaABvAHAAZQAgAHQAaABhAHQAIABpAHQAIAB3AGkAbABsACAAYgBlACAAdQBzAGUAZgB1AGwALAAKACAAKgAgAGIAdQB0ACAAVwBJAFQASABPAFUAVAAgAEEATgBZACAAVwBBAFIAUgBBAE4AVABZADsAIAB3AGkAdABoAG8AdQB0ACAAZQB2AGUAbgAgAHQAaABlACAAaQBtAHAAbABpAGUAZAAgAHcAYQByAHIAYQBuAHQAeQAgAG8AZgAKACAAKgAgAE0ARQBSAEMASABBAE4AVABBAEIASQBMAEkAVABZACAAbwByACAARgBJAFQATgBFAFMAUwAgAEYATwBSACAAQQAgAFAAQQBSAFQASQBDAFUATABBAFIAIABQAFUAUgBQAE8AUwBFAC4AIAAgAFMAZQBlACAAdABoAGUACgAgACoAIABHAE4AVQAgAEEAZgBmAGUAcgBvACAARwBlAG4AZQByAGEAbAAgAFAAdQBiAGwAaQBjACAATABpAGMAZQBuAHMAZQAgAGYAbwByACAAbQBvAHIAZQAgAGQAZQB0AGEAaQBsAHMALgAKACAAKgAKACAAKgAgAFkAbwB1ACAAcwBoAG8AdQBsAGQAIABoAGEAdgBlACAAcgBlAGMAZQBpAHYAZQBkACAAYQAgAGMAbwBwAHkAIABvAGYAIAB0AGgAZQAgAEcATgBVACAAQQBmAGYAZQByAG8AIABHAGUAbgBlAHIAYQBsACAAUAB1AGIAbABpAGMAIABMAGkAYwBlAG4AcwBlAAoAIAAqACAAYQBsAG8AbgBnACAAdwBpAHQAaAAgAHQAaABpAHMAIABwAHIAbwBnAHIAYQBtAC4AIAAgAEkAZgAgAG4AbwB0ACwAIABzAGUAZQAgADwAaAB0AHQAcAA6AC8ALwB3AHcAdwAuAGcAbgB1AC4AbwByAGcALwBsAGkAYwBlAG4AcwBlAHMALwA%2BAC4ACgAgACoALwAKAAoAaQBtAHAAbwByAHQAIAB4ACAAZgByAG8AbQAgACIAagBxAHUAZQByAHkAIgA7AA%3D%3D

Expected result

The following file is emptied:

/*
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

import x from "jquery";

Same as bug #3401.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[dyc3]

This has already been fixed (as shown by the playground). The fix has not been released yet. You can try one of the nightly releases if you need the fix right away.

[fregante]

as shown by the playground

Shown where? The autofix suggests removing the entire block. This screenshot is from the playground:

[fregante]

You can try one of the nightly releases if you need the fix right away.

Unfortunately I'm unable to use prereleases due to this bug:

• Beta tags and commit hashes don't work pre-commit#29

[ematipico]

As for the fix, I think we should follow the new import sorting revamp assumptions, and define the comment as a detached comment.

This comment should be placed as part of the new root in case the file becomes empty, or part of the next statement.