-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Unable to get Biome running in a subfolder of a single-folder workspace #403
Comments
Hey, thanks for reporting. Would you mind creating a minimal reproduction repo using |
Thanks for getting back quickly and apologies for my late response. I've create a minimal reproducing repo at https://github.com/flekschas/biome-issue. Screen.Recording.2024-10-20.at.11.33.23.AM.mp4I wonder if my configuration is incorrect or if this kind of setup is just not supported by Biome. I hope it's the former because you guys did an absolutely fantastic job with Biome 👏 and I would not want to go back to ESLint + Prettier. |
Sorry for the time it took to follow up here. I'm assuming you're expecting Biome to warn about I've opened your repo, and Biome started correctly for your project, as seen in the following screencast. Screen.Recording.2024-11-30.at.16.13.47.mov |
Apologies, this was my mistake. Even if I change biome.mp4Any ideas what the issue might be? I wonder if there's an issue with the biome binary. For a few seconds I saw the following popup but it went away on it's own: When I set |
You shouldn't. You should remove that option. When you set it, the extension tries to use the value that you set. Setting |
Sure, I only tested this as the popup open. In the recorded video I'm not using the setting. So somehow, VSCode isn't able to resolve the local biome binary and is looking for a global one. Is that expected? I was under the impression that adding biome as a dependency ensures that the extension is using the local biome binary (https://biomejs.dev/reference/vscode/#biome-resolution). But somehow it seems like it's not. |
This is indeed the expected behavior. Could you set your logging level to Debug using the |
The debug logs are:
I've played around with the
I've tried the following settings:
|
Depending on your system, this would be something like However, in this case, you're actually better off letting the extension figure out automatically this path. |
Sure but the extension doesn't seem to find the binary in the |
In my case, there was no issue starting the LSP session. Did you reload the window after having installed your node modules ? |
Yes I did. So I figured out what the issue is: I never properly migrated my machine setup to arm64 after I got an Apple silicon macbook. This caused the After migrating by bash version + brew + nvm, the VSCode extension successfully finds the binary. For anyone else who might run into this issue, here's the chain of things I did to fix the problem:
I know this is a very esoteric error but it would be nice if the Biome extension was somehow notifying the user about the issue similar to how npm notifies the user when they try to install a binary that doesn't match their shell. But I also know that this is probably very low of a priority :) Thanks for your help guys and keep up the good work with Biome! |
Thanks for the deets, @flekschas! |
VS Code version
1.93.1
Extension version
v2024.10.131712
Biome version
1.9.4
Operating system
Description
I'm trying to get the Biome VSCode extension running to lint+format JS code that lives in a subfolder of my workspace.
My setup is fairly simply:
My
.vscode/settings.json
isI see that the extension is loaded when looking at the
Output
panel:Apart from that, nothing else is logged, even after I change some files to JS files under
js/src
.Am I missing anything? Should I be concerned about the initial fail to start biome and then the info output saying the extension started?
Steps to reproduce
Create an environment as outlined in
Description
, install VSCode, install the extension, open a JS file underjs/src
and add an unused variable, and finally notice how no hints are shown in the code panel.Expected behavior
See Biome hints in the code editor
Does this issue occur when using the CLI directly?
No
Link to a minimal reproduction
https://github.com/flekschas/biome-issue
Logs
No response
The text was updated successfully, but these errors were encountered: