Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Plugin in WebStorm stopped working #99

Open
1 task done
CostGranda opened this issue Oct 22, 2024 · 8 comments
Open
1 task done

📝Plugin in WebStorm stopped working #99

CostGranda opened this issue Oct 22, 2024 · 8 comments
Labels
Needs reproduction Needs a reproduction Waiting for response Waiting for a response from the author of the issue

Comments

@CostGranda
Copy link

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.16.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Formatter:
  Format with errors:           false
  Indent style:                 Tab
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(true)
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              unset
  Bracket same line:            false
  Quote style:                  Double
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           unset

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
	"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
	"vcs": {
		"enabled": false,
		"clientKind": "git",
		"useIgnoreFile": false
	},
	"files": {
		"ignoreUnknown": false,
		"ignore": []
	},
	"formatter": {
		"enabled": true,
		"indentStyle": "tab"
	},
	"organizeImports": {
		"enabled": true
	},
	"linter": {
		"enabled": true,
		"rules": {
			"recommended": true
		}
	},
	"javascript": {
		"formatter": {
			"quoteStyle": "double"
		}
	}
}

Playground link

https://biomejs.dev/playground/?indentStyle=space&code=aQBtAHAAbwByAHQAIAB7AAoACQBCAHUAaQBsAGQAaQBuAGcALAAKAAkAQwBpAHIAYwBsAGUAVQBzAGUAcgAsAAoACQBDAGwAaQBwAGIAbwBhAHIAZABQAGwAdQBzACwACgAJAEMAbwBuAHQAYQBjAHQALAAKAAkARABvAGwAbABhAHIAUwBpAGcAbgAsAAoACQBSAGUAYwBlAGkAcAB0AFQAZQB4AHQALAAKAAkAUwBlAHQAdABpAG4AZwBzACwACgB9ACAAZgByAG8AbQAgACIAbAB1AGMAaQBkAGUALQByAGUAYQBjAHQAIgA7AAoAaQBtAHAAbwByAHQAIAB7ACAAbgBhAG4AbwBpAGQAIAB9ACAAZgByAG8AbQAgACIAbgBhAG4AbwBpAGQAIgA7AAoACgBlAHgAcABvAHIAdAAgAGUAbgB1AG0AIABSAE8AVQBUAEUAUwBfAFAAQQBUAEgAUwAgAHsACgAJAGQAYQBzAGgAYgBvAGEAcgBkACAAPQAgACIALwBkAGEAcwBoAGIAbwBhAHIAZAAiACwACgAJAHMAZQBsAGwAcwAgAD0AIAAiAC8AZABhAHMAaABiAG8AYQByAGQALwBzAGUAbABsAHMAIgAsAAoACQAiAGMAcgBlAGEAdABlAC0AcwBlAGwAbAAiACAAPQAgACIALwBkAGEAcwBoAGIAbwBhAHIAZAAvAHMAZQBsAGwAcwAvAGMAcgBlAGEAdABlACIALAAKAAkAcgBlAHAAbwByAHQAcwAgAD0AIAAiAC8AZABhAHMAaABiAG8AYQByAGQALwByAGUAcABvAHIAdABzACIALAAKAAkAYwBsAGkAZQBuAHQAcwAgAD0AIAAiAC8AZABhAHMAaABiAG8AYQByAGQALwBjAGwAaQBlAG4AdABzACIALAAKAAkAZQBtAHAAbABvAHkAZQBlAHMAIAA9ACAAIgAvAGQAYQBzAGgAYgBvAGEAcgBkAC8AZQBtAHAAbABvAHkAZQBlAHMAIgAsAAoACQBwAHIAbwBmAGkAbABlACAAPQAgACIALwBkAGEAcwBoAGIAbwBhAHIAZAAvAHAAcgBvAGYAaQBsAGUAIgAsAAoACQBzAGUAdAB0AGkAbgBnAHMAIAA9ACAAIgAvAGQAYQBzAGgAYgBvAGEAcgBkAC8AcwBlAHQAdABpAG4AZwBzACIALAAKAAkAbABvAGcAaQBuACAAPQAgACIALwAiACwACgAJAGwAbwBnAG8AdQB0ACAAPQAgACIALwBsAG8AZwBvAHUAdAAiACwACgB9AAoACgBlAHgAcABvAHIAdAAgAHQAeQBwAGUAIABCAHIAZQBhAGQAYwByAHUAbQBiAEkAdABlAG0AIAA9ACAAewAgAGwAYQBiAGUAbAA6ACAAcwB0AHIAaQBuAGcAOwAgAHUAcgBsADoAIABzAHQAcgBpAG4AZwAgAH0AOwAKAGUAeABwAG8AcgB0ACAAdAB5AHAAZQAgAEIAcgBlAGEAZABjAHIAdQBtAGIASQB0AGUAbQBTAHQAcgB1AGMAdAB1AHIAZQAgAD0AIAB7ACAAbABhAGIAZQBsADoAIABzAHQAcgBpAG4AZwA7ACAAdQByAGwAOgAgAHMAdAByAGkAbgBnACAAfQA7AAoACgBlAHgAcABvAHIAdAAgAGMAbwBuAHMAdAAgAEIAUgBFAEEARABDAFIAVQBNAEIAUwBfAFAAQQBUAEgAUwAgAD0AIAB7AH0AOwAKAAoAaQBuAHQAZQByAGYAYQBjAGUAIABCAHIAZQBhAGQAQwByAHUAbQBiAHMARQBzAFAAYQB0AGgAcwBJAG4AdABlAHIAZgBhAGMAZQAgAHsACgAJAFsAawBlAHkAOgAgAHMAdAByAGkAbgBnAF0AOgAgAHMAdAByAGkAbgBnADsACgB9AAoAZQB4AHAAbwByAHQAIABjAG8AbgBzAHQAIABCAFIARQBBAEQAQwBSAFUATQBCAFMAXwBFAFMAXwBQAEEAVABIAFMAOgAgAEIAcgBlAGEAZABDAHIAdQBtAGIAcwBFAHMAUABhAHQAaABzAEkAbgB0AGUAcgBmAGEAYwBlACAAPQAgAHsACgAJAHUAcwBlAHIAcwA6ACAAIgBVAHMAdQBhAHIAaQBvAHMAIgAsAAoACQBjAGwAaQBlAG4AdABzADoAIAAiAEMAbABpAGUAbgB0AGUAcwAiACwACgAJAHQAaQBtAGUAcwBoAGUAZQB0AHMAOgAgACIAUgBlAGcAaQBzAHQAcgBhAHIAIABJAG4AZwByAGUAcwBvACIALAAKAAkAZQBtAHAAbABvAHkAZQBlAHMAOgAgACIARQBtAHAAbABlAGEAZABvAHMAIgAsAAoACQByAGUAcABvAHIAdABzADoAIAAiAFIAZQBwAG8AcgB0AGUAcwAiACwACgAJAGwAaQBxAHUAaQBkAGEAdABpAG8AbgA6ACAAIgBOAPMAbQBpAG4AYQAiACwACgAJAHAAcgBvAGYAaQBsAGUAOgAgACIAUABlAHIAZgBpAGwAIgAsAAoACQBjAHIAZQBhAHQAZQA6ACAAIgBDAHIAZQBhAHIAIgAsAAoAfQA7AAoACgBlAHgAcABvAHIAdAAgAGMAbwBuAHMAdAAgAEIAUgBFAEEARABDAFIAVQBNAEIAUwBfAEQARQBfAFAAQQBUAEgAUwAgAD0AIAB7AAoACQBzAGUAbABsAHMAOgAgAHsAIABsAGEAYgBlAGwAOgAgACIAVgBlAG4AdABhACIALAAgAHUAcgBsADoAIABSAE8AVQBUAEUAUwBfAFAAQQBUAEgAUwAuAHMAZQBsAGwAcwAgAH0ALAAKAAkAcgBlAHAAbwByAHQAcwA6ACAAewAgAGwAYQBiAGUAbAA6ACAAIgBSAGUAcABvAHIAdABlAHMAIgAsACAAdQByAGwAOgAgAFIATwBVAFQARQBTAF8AUABBAFQASABTAC4AcgBlAHAAbwByAHQAcwAgAH0ALAAKAAkAYwBsAGkAZQBuAHQAcwA6ACAAewAgAGwAYQBiAGUAbAA6ACAAIgBDAGwAaQBlAG4AdABlAHMAIgAsACAAdQByAGwAOgAgAFIATwBVAFQARQBTAF8AUABBAFQASABTAC4AYwBsAGkAZQBuAHQAcwAgAH0ALAAKAAkAZQBtAHAAbABvAHkAZQBlAHMAOgAgAHsAIABsAGEAYgBlAGwAOgAgACIARQBtAHAAbABlAGEAZABvAHMAIgAsACAAdQByAGwAOgAgAFIATwBVAFQARQBTAF8AUABBAFQASABTAC4AZQBtAHAAbABvAHkAZQBlAHMAIAB9ACwACgAJAHAAcgBvAGYAaQBsAGUAOgAgAHsAIABsAGEAYgBlAGwAOgAgACIAUABlAHIAZgBpAGwAIgAsACAAdQByAGwAOgAgAFIATwBVAFQARQBTAF8AUABBAFQASABTAC4AcAByAG8AZgBpAGwAZQAgAH0ALAAKAAkAYwByAGUAYQB0AGUAOgAgAHsAIABsAGEAYgBlAGwAOgAgACIAQwByAGUAYQByACIALAAgAHUAcgBsADoAIABSAE8AVQBUAEUAUwBfAFAAQQBUAEgAUwAuAHAAcgBvAGYAaQBsAGUAIAB9ACwACgB9ADsACgAKAC8AKgAqAAoAIAAqACAASABlAGwAcABzACAAdABvACAAcwBoAG8AdwAgAHQAbwAgAHQAaABlACAAdQBzAGUAcgAgAHQAaABlACAAcABhAHQAaAAgAHIAbwB1AHQAZQAgAHQAcgBhAG4AcwBsAGEAdABlAGQAIABhAG4AZAAgAGMAYQBwAGkAdABhAGwAaQB6AGUAZAAgAGYAbwByACAAdABoAGUAIABiAHIAZQBhAGQAYwByAHUAbQBiAAoAIAAqACAAQABwAGEAcgBhAG0AIAByAG8AdQB0AGUACgAgACoALwAKAGUAeABwAG8AcgB0ACAAZgB1AG4AYwB0AGkAbwBuACAAZwBlAHQAQgByAGUAYQBkAGMAc

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Freezystem
Copy link

Formatting is not working on auto-save but works when using CTRL + ALT + L.
Plugin is also mentionning (and maybe using) deprecated --apply flag.

@ematipico ematipico transferred this issue from biomejs/biome Nov 5, 2024
@ematipico
Copy link
Member

The plugin is currently unmaintained, PRs are welcome

@denbezrukov
Copy link
Contributor

@Freezystem @CostGranda

Could you please provide a minimal reproducible example?

@denbezrukov denbezrukov added Needs reproduction Needs a reproduction Waiting for response Waiting for a response from the author of the issue labels Nov 10, 2024
@Freezystem
Copy link

I actually found out it was working as expected after checking my settings.
I just though I had to only check the second run safe fixes on save to format to be executed.

image
Adding the first option run format on save fixes it.

The second options is maybe not enough clear and may be named: run linter and apply safe fixes on save instead.

@denbezrukov
Copy link
Contributor

@Freezystem thank you for your answer.
I think that the checkbox "Run Format on Save" is redundant because the plugin formats via LSP; however, we need to turn it on explicitly in settings.
image

@Freezystem
Copy link

hmm.. ok so this also works (I tried it):
image
Is there a fundamental difference between this configuration and the one you screened ?

@denbezrukov
Copy link
Contributor

@Freezystem
It seems the same.
I want to remove that checkbox then I fix one issue with formatting via lsp and autofixing.
There is a race sometimes😶

@Freezystem
Copy link

After trying that config for some hours it seems that formatting through LSP does not work exactly the same way as the biome check command.
It may be related to the issue your are talking about.
Anyway for the moment I reverted to only check the first two checkboxes from biome plugin and unchecked the "Reformat code" one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs reproduction Needs a reproduction Waiting for response Waiting for a response from the author of the issue
Projects
None yet
Development

No branches or pull requests

4 participants