Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of blocksize_parameter #434

Open
FynnBe opened this issue Nov 8, 2024 · 2 comments
Open

Improve handling of blocksize_parameter #434

FynnBe opened this issue Nov 8, 2024 · 2 comments
Assignees

Comments

@FynnBe
Copy link
Member

FynnBe commented Nov 8, 2024

If a high blocksize_parameter is given to predict it fails if the actual sample is smaller than the deduced block shape.
For simple blocksize_parameter values (integers) a smaller value could be chosen automatically to avoid this.

@FynnBe FynnBe self-assigned this Nov 8, 2024
@falibabaei
Copy link

Hi Fynn,

Would it be possible to pad the input to avoid this issue, rather than choosing a smaller value for the blocksize_parameter?

@FynnBe
Copy link
Member Author

FynnBe commented Nov 11, 2024

Would it be possible to pad the input to avoid this issue, rather than choosing a smaller value for the blocksize_parameter?

yes, to some extend. My plan is actually to do both.
As we wouldn't want to pad more than we need to get a valid shape.
Otherwise one might accidentally pad to a multiple of the image size, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants