Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting the session fails silently when websockets are blocked #14

Open
binford2k opened this issue Mar 28, 2017 · 0 comments
Open

starting the session fails silently when websockets are blocked #14

binford2k opened this issue Mar 28, 2017 · 0 comments

Comments

@binford2k
Copy link
Owner

If a firewall or DPI between the user and the server alters the websocket packets (e.g., degrading them to standard HTTP) then the terminal just silently fails to load. In the js console you see unexpected 200 statuses. It's expecting a 101 Switching Protocols instead.

This indicates that a websocket connection was attempted, but the packets weren't valid, so the server responds with the standard HTML page. The WebSocket() call in js doesn't know how to respond to that and just fails.

Instead, we should detect that, or catch errors, and display an informative error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant