Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug - miscellaneous minor fixes (found during tests) #207

Open
5 of 6 tasks
topi-chan opened this issue Mar 19, 2021 · 0 comments
Open
5 of 6 tasks

Fixing bug - miscellaneous minor fixes (found during tests) #207

topi-chan opened this issue Mar 19, 2021 · 0 comments

Comments

@topi-chan
Copy link
Member

topi-chan commented Mar 19, 2021

Issue
There are some bugs which should be fixed.

Tasks

  • 1/ after hr user tries to add an employee to his company - if the employee is already registered into another company, the hr user can see "dodano pracownika" banner, but nothing happens (he should see a different banner) - @topi-chan

  • 2/ serializers may be reviewed - if there aren't unnecessary fields (i.a. for security reasons); @adam-sas-on @topi-chan

  • 3/ we can add url '/login' for intuitive login sub-site (currently this url is not registered); @topi-chan

  • 4/ email template is too bright / contrast and should be redesigned @annapakula & @Michal-Roszyk

  • 5/ page tittles are in English (for example - "employee dashboard"); - to be checked

  • 6/ after a form is saved by the user (an employee) or sent to hr manager he is not redirected into neither list sub-site, nor main page, which may be unintuitive for the user.

First issues were identified by myself, last one by Michał.
...to be continued?

For checks: deleting already send form is not working:
django.db.models.deletion.ProtectedError: ("Cannot delete some instances of model 'Package' because they are referenced through protected foreign keys: 'PackagesUsers.package'.", <itertools.chain object at 0x7fe88baa4dc0>)
[20/Mar/2021 00:57:23] "DELETE /api/package/8/ HTTP/1.1" 500 16871

@topi-chan topi-chan added the bug Something isn't working label Mar 19, 2021
@topi-chan topi-chan self-assigned this Mar 19, 2021
@maggienow maggienow added this to To do in 22.03- 26.03 Mar 22, 2021
@annapakula annapakula self-assigned this Mar 29, 2021
@maggienow maggienow added this to To do in 29.03 - 2.04 Mar 29, 2021
@maggienow maggienow added this to In progress in 6.04 - 9.04 Apr 6, 2021
@adam-sas-on adam-sas-on added this to To do in 12.04 - 16.04 Apr 13, 2021
@maggienow maggienow added this to In progress in 14.06 - 18.06 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants