Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bad offset #55

Open
billgraziano opened this issue Aug 5, 2020 · 2 comments
Open

Handle bad offset #55

billgraziano opened this issue Aug 5, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@billgraziano
Copy link
Owner

The offset 3964416 is invalid for log file "E:\MSSQL13.XYZ\MSSQL\Log\logstash_feed_0_132410484664200000.xel

If we get an invalid offset, try to read the next offset (or file) and use that.

How to log that this happened and we lost events?
@billgraziano
Copy link
Owner Author

billgraziano commented Mar 31, 2021 •
edited
Loading

I think the standard session is writing lots of events we don't care about. And I think we're only advancing "xestate" when we write an event. We should advance it even if there are no events we care about.

@billgraziano billgraziano added bug Something isn't working enhancement New feature or request labels Mar 31, 2021
@billgraziano
Copy link
Owner Author

I think this is working right. But I'd really rather put all the events into an array and then write them when the offset changes right before we write the state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billgraziano