-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide filter for filtering the image url. #17
Comments
If the upload directory is changing, shouldn't that be reflected in I'm working on a site right now with a non-standard uploads directory and this plugin is working fine with it. In wp-config.php I have: |
Hi Bill, I think this is because Bedrock changes the whole content dir instead of just the uploads dir. Config::define('CONTENT_DIR', '/app'); I currently manually implemented this hook to search/replace the /app/ part with /wp-content/ and then the plugin points to the right files on the production site. |
Hi @billerickson, any idea's on how to do this?? Can you make Bedrock work with your plujgin without manually doing the things @Levdbas descibed above? (Which abviously takes costs a lot of time and effort) |
I've never used Bedrock before so am not sure what changes are required to make it compatible. If you can submit a pull request that fixes the issues in Bedrock, I'll merge it. My understanding was that the code at the top of this thread fixed the location in Bedrock. If you just add that to a mu-plugin in your local environment (I think) no changes are required to the plugin. Obviously we can't merge that code into the plugin as it would break images for all non-Bedrock environments. |
Hi Bill, managed to solve it for this case, although I had to edit the plugin code. |
When switching from a default WordPress installation to a Bedrock based WordPress install or vice versa, the upload folder location changes. It would be nice if there would be a filter in the update_image_url() method where you can filter the image path.
Then things like this are possible.
let me know your thoughts.
The text was updated successfully, but these errors were encountered: