Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint #55

Open
billdeitrick opened this issue Sep 6, 2022 · 5 comments
Open

Update pylint #55

billdeitrick opened this issue Sep 6, 2022 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@billdeitrick
Copy link
Owner

We had to pin pylint with the new CI pipeline because the newer version was throwing various linting errors. Need unpin pylint and resolve these errors.

@billdeitrick billdeitrick added the bug Something isn't working label Sep 6, 2022
@billdeitrick billdeitrick added the help wanted Extra attention is needed label Sep 22, 2022
@billdeitrick billdeitrick added this to the v1.2.0 Release milestone Sep 22, 2022
@pastorhudson
Copy link
Collaborator

This is related to issue #57

@07pepa
Copy link
Contributor

07pepa commented Oct 11, 2022

i may help

@pastorhudson
Copy link
Collaborator

I have pycharm pro I can just tell it to fix all the code formatting and see if it works with the new pylint. Or we could try something like black as a pre-commit, but that will add some complexity.

@pastorhudson
Copy link
Collaborator

I read that as "I may need help" 😅 @07pepa id you want to tackle this that would be great!

@07pepa
Copy link
Contributor

07pepa commented Oct 11, 2022

Hehe yea this is "hell" of being non native english speaker.... In 🇨🇿 (czech} language I could even drop "I" and from form of verb of "may" you could backtrack that i ment myself

well i am just rolling Comunity edition (and i may suggest others like flake8 as well} but worth checking other big project like pydantic or fastapi

and i am not againts precomit if there is explanation with simple fix (like just run this and that) and you will be able to comit
i thing it will not be a problem for other commiters

but what i would like that code will not shine like christmass tree in pycharm (so a format as close as it can be)

@billdeitrick billdeitrick removed this from the v1.2.0 Release milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants