Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: work with Dancer2 #99

Open
bigpresh opened this issue May 21, 2017 · 2 comments
Open

Feature: work with Dancer2 #99

bigpresh opened this issue May 21, 2017 · 2 comments
Labels

Comments

@bigpresh
Copy link
Owner

Sadly, Dancer::Plugin::SimpleCRUD is currently D1-only.

I very much want to make it work with Dancer2, but just haven't had the time to spend on it yet - my spare time is spread thinly, and my paying work involves D1 primarily currently.

I would ideally like to consider trying to implement a D1/D2 plugin base class which provides a DSL for plugins to use that handles the D1/D2 differences under the hood, but I'm not sure how feasible that is.

@joshrabinowitz
Copy link
Contributor

Should we consider putting D:P:SimpleCRUD into maint mode and porting this to D2:P:SimpleCRUD?

@bigpresh
Copy link
Owner Author

I wonder if we can take an approach like D::P::Database, where we ended up with a shared core which is then used by D::P::Database and D2::P::Database - so the actual plugins are an as-thin-as-possible wrapper around the actual core.

May or may not work as well here, as SimpleCRUD has some hairier interactions with Dancer I believe.

I still would really really like to come up with some kind of plugin abstraction that provides the same interface for plugins running under both Dancers, so you could as a plugin author just inherit from it and use its interface, and know that your plugin will work in both - but I am struggling for time lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants