Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public submodule #1670

Merged

Conversation

jmahony
Copy link
Contributor

@jmahony jmahony commented Nov 21, 2024

What/Why?

The submodule doesn't seem to be used and it's causing my build in Netlify to fail with the error:

6:48:19 AM: Failed during stage 'preparing repo': Error checking out submodules: fatal: No url found for submodule path 'public' in .gitmodules
: exit status 128: fatal: No url found for submodule path 'public' in .gitmodules
: exit status 128
6:48:19 AM: Error checking out submodules: fatal: No url found for submodule path 'public' in .gitmodules
: exit status 128
6:48:19 AM: Failing build: Failed to prepare repo

Testing

@jmahony jmahony requested a review from a team as a code owner November 21, 2024 07:00
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 8852886

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 21, 2024

@jmahony is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this! Definitely glanced over this.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Nov 21, 2024 2:37pm

@chanceaclark chanceaclark changed the base branch from main to external-pr November 21, 2024 14:49
@chanceaclark chanceaclark merged commit 64e723d into bigcommerce:external-pr Nov 21, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants