Skip to content

Returning on first error #1

@wvpv

Description

@wvpv

Hey, I'm curious why you break out of the entire function with the return when you encounter one file that doesn't exist or if the download of the file fails.

Seems like you'd want to continue iterating.

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L45

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L50

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions