Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for overridden sidecar fields #117

Open
effigies opened this issue Nov 15, 2024 · 0 comments
Open

Add warning for overridden sidecar fields #117

effigies opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement New feature or request target: dev

Comments

@effigies
Copy link
Contributor

bids-standard/bids-specification#1834 proposes RECOMMENDING against overriding JSON values as a source of confusion ("I can see this value in my JSON, why is the tool using a different one?")

This should be relatively easy to implement by checking for overlap here:

this.sidecar = { ...json, ...this.sidecar }
Object.keys(json).map((x) => this.sidecarKeyOrigin[x] ??= file.path)

Added a target: dev label to indicate PRs should target the dev branch, not main, as this would be a spec change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request target: dev
Projects
None yet
Development

No branches or pull requests

1 participant