Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up to 18 and 19 digit credit cards #154

Open
lcastillo-evc opened this issue Apr 30, 2019 · 6 comments
Open

Support up to 18 and 19 digit credit cards #154

lcastillo-evc opened this issue Apr 30, 2019 · 6 comments
Labels
Enhancement A new feature or a better behaviour request.

Comments

@lcastillo-evc
Copy link

Many of the major credit card carriers are moving or have moved to cards with up to 18 and 19 digits. Are you planning to add support for this any time soon?

Carrier Affected | # of Digits
China UnionPay | 16 - 19
Discover Card | 16 or 19
Maestro | 16 - 19
Visa | 16, 18 or 19
JCB | 16 - 19

@bhrott
Copy link
Owner

bhrott commented Apr 30, 2019

Hey, @lcastillo88 I didn't know about that.
Thanks for reporting.

@bhrott bhrott added the Enhancement A new feature or a better behaviour request. label Apr 30, 2019
@AleksandrZhukov
Copy link

@lcastillo88 can you show some proofs about this, eg about visa? I tried to google something but didn't find anything 😞

@AleksandrZhukov
Copy link

I've found this useful article - https://baymard.com/checkout-usability/credit-card-patterns

@AleksandrZhukov
Copy link

@benhurott Pls check the PR #164, I'm not sure about some pieces, will nice if you can make a code review 😉

@lcastillo-evc
Copy link
Author

Hi @AleksandrZhukov thanks for finding an article about this. The truth of the matter is that I'm not quite sure when this new card length standard will be adopted but it would be nice to have this project support it when it does.

@AleksandrZhukov
Copy link

There is a nice lib that describes card standards - https://github.com/braintree/credit-card-type, I think will be nice to report new details or issues there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A new feature or a better behaviour request.
Projects
None yet
Development

No branches or pull requests

3 participants