Skip to content

Commit 57ec942

Browse files
committed
Add docs about github tokens for cherrypicking
Recently, I performed a cherry pick for the first time. When I ran ./hack/cherry_pick_pull.sh after setting up all the env variables, I was asked for my github password. When I gave my actual github password it threw a 404 not found which confused me. I then came across this mislav/hub#2655 (comment) . I created a github token post which I was able to cherry pick successfully. The hub project team is looking to fix it but until then I feel that we should document it. Do let me know if I did something wrong here in the cherry pick process.
1 parent 42670a7 commit 57ec942

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

contributors/devel/sig-release/cherry-picks.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ branches.
2727
- Have `hub` installed, which is most easily installed via
2828
`go get github.com/github/hub` assuming you have a standard golang
2929
development environment.
30+
- A github token which has permissions to create a PR in an upstream branch.
3031

3132
## What Kind of PRs are Good for Cherry Picks
3233

@@ -89,6 +90,9 @@ patch release branches.
8990
release you want to cherry pick to. Cherry picks should be applied to all
9091
[active](https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#detailed-release-history-for-active-branches)
9192
release branches where the fix is applicable.
93+
94+
- When hub intimates you for your github password, provide the created github token rather than your actual github password.
95+
9296

9397
- Your cherry pick PR will immediately get the
9498
`do-not-merge/cherry-pick-not-approved` label.

0 commit comments

Comments
 (0)