The string returned by inet_ntoa() resides in a static memory area

job · job · commit 270e04dd2391 · 2021-08-17T22:20:16.000Z
diff --git a/bgpq4_printer.c b/bgpq4_printer.c
@@ -1375,10 +1375,10 @@ bgpq4_print_ceacl(struct sx_radix_node *n, void *ff)
 			    inet_ntoa(n->prefix->addr.addr));
 		}
 
-		if (wildmask.s_addr)
-			fprintf(f, "%s %s\n", inet_ntoa(mask),
-			    inet_ntoa(wildmask));
-		else {
+		if (wildmask.s_addr) {
+			fprintf(f, "%s ", inet_ntoa(mask));
+			fprintf(f, "%s\n", inet_ntoa(wildmask));
+		} else {
 			fprintf(f, "host %s\n", inet_ntoa(mask));
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -1375,10 +1375,10 @@ bgpq4_print_ceacl(struct sx_radix_node n, void ff)`
`1375`	`1375`	`inet_ntoa(n->prefix->addr.addr));`
`1376`	`1376`	`}`
`1377`	`1377`
`1378`		`- if (wildmask.s_addr)`
`1379`		`- fprintf(f, "%s %s\n", inet_ntoa(mask),`
`1380`		`- inet_ntoa(wildmask));`
`1381`		`- else {`
	`1378`	`+ if (wildmask.s_addr) {`
	`1379`	`+ fprintf(f, "%s ", inet_ntoa(mask));`
	`1380`	`+ fprintf(f, "%s\n", inet_ntoa(wildmask));`
	`1381`	`+ } else {`
`1382`	`1382`	`fprintf(f, "host %s\n", inet_ntoa(mask));`
`1383`	`1383`	`}`
`1384`	`1384`	`} else {`