Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prom-client v15 #66

Open
cbix opened this issue Dec 4, 2023 · 4 comments
Open

Support prom-client v15 #66

cbix opened this issue Dec 4, 2023 · 4 comments

Comments

@cbix
Copy link

cbix commented Dec 4, 2023

The peer-dependency prom-client recently released version 15.0.0, however when installing that I get

npm ERR! Could not resolve dependency:
npm ERR! peer prom-client@"^12.0.0 || ^13.0.0 || ^14.0.0" from @bmatei/[email protected]
npm ERR! node_modules/@bmatei/apollo-prometheus-exporter
npm ERR!   @bmatei/apollo-prometheus-exporter@"^3.0.0" from the root project

I didn't test for full compatibility yet but if it's not a breaking change, it might be sufficient to just add || ^15.0.0.

@glensc
Copy link

glensc commented Jan 18, 2024

@cbix so send a PR?

maybe even better add >= 15, so, that if some version is broken it can't be dealt with, otherwise assume working.

@lala7573
Copy link

lala7573 commented Mar 4, 2024

It doesn't work when you simply update the version. It has type error

@bmatei/apollo-prometheus-exporter/context.d.ts:31:28 - error TS2314: Generic type 'DefaultMetricsCollectorConfiguration<T>' requires 1 type argument(s).

@Jhonas0403
Copy link

I have the same error, at the moment I work with prom-client v.14.0.2 but when we work with prom client v15.0.0 we have the same error of @lala7573

@tigerabrodi
Copy link

its interesting how they're using version 3 of prometheus and 15.1 of prom-client: https://github.com/aahlborn/omnivore/blob/67c5de6512ebdf7bf3b03390d928507f34a54a41/packages/api/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants