Skip to content

Refactor 2d_viewport_to_world example with let chains #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Refactor 2d_viewport_to_world example with let chains #20090

merged 1 commit into from
Jul 14, 2025

Conversation

tim-blackbird
Copy link
Contributor

Objective

Make use of let chains to reduce LoC where we previously used let else to cut down on indentation. Best of both worlds.
Hmm, déjà vu?

@tim-blackbird tim-blackbird added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 11, 2025
@tim-blackbird tim-blackbird added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 11, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 14, 2025
Merged via the queue into bevyengine:main with commit ec6dd7e Jul 14, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynn-lumen lynn-lumen lynn-lumen approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tim-blackbird @lynn-lumen @alice-i-cecile