supress CS0618 for ChartPointPointerDownCommand

beto-rodriguez · beto-rodriguez · commit c4e56093688b · 2024-12-15T12:53:57.000-06:00
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/CartesianChart.axaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/CartesianChart.axaml.cs
@@ -851,7 +851,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PieChart.axaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PieChart.axaml.cs
@@ -712,7 +712,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PolarChart.axaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PolarChart.axaml.cs
@@ -787,7 +787,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKCartesianChart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKCartesianChart.cs
@@ -113,6 +113,7 @@ public SKCartesianChart(ICartesianChartView view) : this()
     public FindingStrategy FindingStrategy { get; set; }
 
     /// <inheritdoc cref="ICartesianChartView.FindingStrategy"/>
+    [Obsolete($"Renamed to {nameof(FindingStrategy)}")]
     public TooltipFindingStrategy TooltipFindingStrategy { get; set; }
 
     /// <inheritdoc cref="IChartView.Legend"/>
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKGeoMap.cs b/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKGeoMap.cs
@@ -31,7 +31,7 @@
 
 namespace LiveChartsCore.SkiaSharpView.SKCharts;
 
-/// <inheritdoc cref="IGeoMapView{SkiaSharpDrawingContext}"/>
+/// <inheritdoc cref="IGeoMapView"/>
 public class SKGeoMap : InMemorySkiaSharpChart, IGeoMapView
 {
     private readonly GeoMapChart _core;
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/CartesianChart.xaml.cs
@@ -858,7 +858,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnVisualElementPointerDown(
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/GeoMap.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/GeoMap.xaml.cs
@@ -30,6 +30,7 @@
 using LiveChartsCore.Kernel;
 using LiveChartsCore.Measure;
 using LiveChartsCore.Motion;
+using LiveChartsCore.Painting;
 using LiveChartsCore.SkiaSharpView.Drawing;
 using LiveChartsCore.SkiaSharpView.Painting;
 using Microsoft.Maui;
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/PieChart.xaml.cs
@@ -725,7 +725,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/PolarChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Maui/PolarChart.xaml.cs
@@ -805,7 +805,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/CartesianChart.xaml.cs
@@ -891,7 +891,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/PieChart.xaml.cs
@@ -738,7 +738,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/PolarChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.Uno.WinUI/PolarChart.xaml.cs
@@ -820,7 +820,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/CartesianChart.xaml.cs
@@ -887,7 +887,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/PieChart.xaml.cs
@@ -770,7 +770,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)
diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/PolarChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.WinUI/PolarChart.xaml.cs
@@ -834,7 +834,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point
         if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);
 
         ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));
+#pragma warning disable CS0618 // Type or member is obsolete
         ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)

Original file line number	Diff line number	Diff line change
`@@ -851,7 +851,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`851`	`851`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`852`	`852`
`853`	`853`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`854`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`854`	`855`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`856`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`855`	`857`	`}`
`856`	`858`
`857`	`859`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`
Original file line number	Diff line number	Diff line change
`@@ -712,7 +712,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`712`	`712`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`713`	`713`
`714`	`714`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`715`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`715`	`716`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`717`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`716`	`718`	`}`
`717`	`719`
`718`	`720`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`
Original file line number	Diff line number	Diff line change
`@@ -787,7 +787,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`787`	`787`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`788`	`788`
`789`	`789`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`790`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`790`	`791`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`792`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`791`	`793`	`}`
`792`	`794`
`793`	`795`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`
`32`	`32`	`namespace LiveChartsCore.SkiaSharpView.SKCharts;`
`33`	`33`
`34`		`-/// <inheritdoc cref="IGeoMapView{SkiaSharpDrawingContext}"/>`
	`34`	`+/// <inheritdoc cref="IGeoMapView"/>`
`35`	`35`	`public class SKGeoMap : InMemorySkiaSharpChart, IGeoMapView`
`36`	`36`	`{`
`37`	`37`	`private readonly GeoMapChart _core;`
Original file line number	Diff line number	Diff line change
`@@ -858,7 +858,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`858`	`858`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`859`	`859`
`860`	`860`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`861`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`861`	`862`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`863`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`862`	`864`	`}`
`863`	`865`
`864`	`866`	`void IChartView.OnVisualElementPointerDown(`
Original file line number	Diff line number	Diff line change
`@@ -725,7 +725,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`725`	`725`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`726`	`726`
`727`	`727`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`728`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`728`	`729`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`730`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`729`	`731`	`}`
`730`	`732`
`731`	`733`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`
Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`805`	`805`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`806`	`806`
`807`	`807`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`808`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`808`	`809`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`810`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`809`	`811`	`}`
`810`	`812`
`811`	`813`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`
Original file line number	Diff line number	Diff line change
`@@ -891,7 +891,9 @@ void IChartView.OnDataPointerDown(IEnumerable<ChartPoint> points, LvcPoint point`
`891`	`891`	`if (DataPointerDownCommand is not null && DataPointerDownCommand.CanExecute(points)) DataPointerDownCommand.Execute(points);`
`892`	`892`
`893`	`893`	`ChartPointPointerDown?.Invoke(this, points.FindClosestTo(pointer));`
	`894`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`894`	`895`	`ChartPointPointerDownCommand?.Execute(points.FindClosestTo(pointer));`
	`896`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`895`	`897`	`}`
`896`	`898`
`897`	`899`	`void IChartView.OnHoveredPointsChanged(IEnumerable<ChartPoint>? newPoints, IEnumerable<ChartPoint>? oldPoints)`