Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not appear to actually work #3

Open
markerikson opened this issue Apr 17, 2023 · 2 comments
Open

Extension does not appear to actually work #3

markerikson opened this issue Apr 17, 2023 · 2 comments

Comments

@markerikson
Copy link

Tried out the extension on a couple of the Redux repos, and it isn't doing anything at all :(

Steps to reproduce:

  • Does not work in Redux Toolkit
    1. Clone https://github.com/reduxjs/redux-toolkit
    2. Open packages/toolkit/src/tests/createSlice.typetest.ts
    3. On line 199, add type t1 = typeof counter.
    4. Run the "TypeScript > Reveal Types" command
    5. Note that a blank createSlice.typetest.d.ts VS Code tab opens, but it's empty
  • Does not work in Reselect
    1. Clone https://github.com/reduxjs/reselect
    2. Open typescript_test/test.ts
    3. On line 493, add type t1 = typeof selector2
    4. Run the "TypeScript > Reveal Types" command
    5. Note that no tab opens up at all, and nothing appears to happen
@betafcc
Copy link
Owner

betafcc commented Apr 17, 2023

I may not have tested it properly on older vscode versions, will reproduce this case on 1.64

@markerikson
Copy link
Author

FWIW this happened after I updated to the latest v1.77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants