Set id as the PRIMARY KEY of AttachmentsIndex for Pg

This is consistent with mysql's fulltext table. As id is the primary
key, DB automatically indexes the column which helps performance
especially for the following SQL that is called quite frequently when
indexing data:

    SELECT MAX(id) FROM AttachmentsIndex

Mainly to support customized fulltext table name, we implement the
upgrade in Perl instead of SQL. Use "indexes" instead of "content"
considering the database handle "content" uses usually doesn't have the
permission to alter tables, not mentioning that it's more like an index
change.

Author: sunnavy

etc/upgrade/5.0.6/indexes

@@ -0,0 +1,19 @@
+use strict;
+use warnings;
+
+if ( RT->Config->Get('DatabaseType') eq 'Pg' ) {
+    my $fulltext = RT->Config->Get('FullTextSearch');
+    if ( my $table = $fulltext->{Table} ) {
+        my $handle = RT->DatabaseHandle;
+        if ( my $indexes = { $handle->Indexes }->{ lc $table } ) {
+            if ( !grep { $_ eq lc "${table}_pkey" } @$indexes ) {
+                my $res = $handle->dbh->do("ALTER TABLE IF EXISTS $table ADD PRIMARY KEY(id)");
+                if ( !$res ) {
+                    RT->Logger->error("Could not add PRIMARY KEY to table $table");
+                }
+            }
+        }
+    }
+}
+
+1;

sbin/rt-setup-fulltext-index.in

@@ -327,7 +327,8 @@ elsif ( $DB{'type'} eq 'Pg' ) {
         push @schema, split /;\n+/, <<SCHEMA;
 CREATE TABLE $table (
     id BIGSERIAL,
-    $column tsvector
+    $column tsvector,
+    PRIMARY KEY (id)
 );
 GRANT SELECT, INSERT, UPDATE, DELETE ON $table TO "$DB{user}"
 SCHEMA