Use role Name/GroupType in case corresponding role groups do not exist yet

Custom role groups could be absent if the corresponding custom roles
were created/applied after some assets or the lazy option is enabled.

Author: sunnavy

share/html/Asset/Elements/EditRoleMembers

@@ -52,14 +52,14 @@ $Recursively => 0
 </%args>
 <%init>
 my $Group = $Object->RoleGroup($Role);
-my $field_name = "RemoveRoleMember-" . $Group->Name;
+my $field_name = "RemoveRoleMember-" . $Role;
 </%init>
 <ul class="role-members list-group list-group-compact">
 % my $Users = $Group->UserMembersObj( Recursively => $Recursively );
 % if ($Object->Role($Role)->{Single}) {
 % my $user = $Users->First || RT->Nobody;
   <li class="list-group-item">
-    <input class="form-control selectpicker" type="text" value="<% $user->Name %>" name="SetRoleMember-<% $Group->Name %>" id="SetRoleMember-<% $Group->Name %>" data-autocomplete="Users" data-autocomplete-return="Name" />
+    <input class="form-control selectpicker" type="text" value="<% $user->Name %>" name="SetRoleMember-<% $Role %>" id="SetRoleMember-<% $Role %>" data-autocomplete="Users" data-autocomplete-return="Name" />
   </li>
 % } else {
 % while ( my $user = $Users->Next ) {

t/assets/web.t

@@ -145,6 +145,90 @@ diag "Bulk update";
     # TODO: test more bulk update actions
 }
 
+diag "People update";
+{
+    my $asset = create_asset( Name => "Test asset", Catalog => $catalog->Id );
+    $m->get_ok( '/Asset/Display.html?id=' . $asset->Id );
+    $m->follow_link_ok( { text => 'People' } );
+
+    my $form = $m->form_id('ModifyAssetPeople');
+    my $owner_input = $form->find_input('SetRoleMember-Owner');
+    ok( $owner_input, 'Found owner input' );
+    is( $owner_input->value, 'Nobody', 'Default owner is Nobody' );
+    $m->submit_form_ok(
+        {
+            fields => {
+                'SetRoleMember-Owner' => 'root',
+            },
+            button => 'Update',
+        },
+        'Submit form ModifyAssetPeople'
+    );
+    $m->text_contains('Owner set to root');
+
+    $form = $m->form_id('ModifyAssetPeople');
+    $owner_input = $form->find_input('SetRoleMember-Owner');
+    ok( $owner_input, 'Found owner input' );
+    is( $owner_input->value, 'root', 'Input value of owner is root' );
+
+    my $staff = RT::Test->load_or_create_group('Staff');
+    $m->submit_form_ok(
+        {
+            fields => {
+                'AddUserRoleMember-Role' => 'Contact',
+                AddUserRoleMember => 'alice@localhost',
+                'AddGroupRoleMember-Role' => 'HeldBy',
+                AddGroupRoleMember => 'Staff',
+            },
+            button => 'Update',
+        },
+        'Submit form ModifyAssetPeople'
+    );
+    $m->text_contains('Member added: alice@localhost');
+    $m->text_contains('Member added: Staff');
+
+    $form = $m->form_id('ModifyAssetPeople');
+    my $alice = RT::Test->load_or_create_user( Name => 'alice@localhost' );
+    $m->tick('RemoveRoleMember-Contact', $alice->Id);
+    $m->tick('RemoveRoleMember-HeldBy', $staff->Id);
+
+    $m->submit_form_ok(
+        {
+            button => 'Update',
+        },
+        'Submit form ModifyAssetPeople'
+    );
+    $m->text_contains('Member deleted');
+
+
+    # Add manager later to test if the page works with absent role groups.
+    my $manager = RT::CustomRole->new( RT->SystemUser );
+    ok(
+        $manager->Create(
+            Name       => 'Manager',
+            LookupType => RT::Asset->CustomFieldLookupType,
+            MaxValues  => 1,
+        )
+    );
+    ok( $manager->AddToObject( $catalog->Id ) );
+
+    $m->reload;
+    $form = $m->form_id('ModifyAssetPeople');
+    my $manager_input = $form->find_input( 'SetRoleMember-' . $manager->GroupType );
+    ok( $manager_input, 'Found manager input' );
+    is( $manager_input->value, 'Nobody', 'Default manager is Nobody' );
+    $m->submit_form_ok(
+        {
+            fields => {
+                'SetRoleMember-' . $manager->GroupType => 'root',
+            },
+            button => 'Update',
+        },
+        'Submit form ModifyAssetPeople'
+    );
+    $m->text_contains('Manager set to root');
+}
+
 # XXX TODO: test other modify pages
 
 done_testing;