Merge branch '5.0/inline-edit-always-cfs' into 5.0-trunk

Author: sunnavy

share/html/Elements/EditCustomFieldSelect

@@ -62,7 +62,7 @@
 %   if ( $checktype eq 'radio' ) {
 % if ( $show_empty_option ) {
   <div class="none custom-control custom-radio">
-    <input class="none custom-control-input" id="<% $name %>-none" type="<% $checktype %>" name="<% $name %>" id="<% $name %>-none" value="" <% keys %default ? '' : ' checked="checked"' |n%> />
+    <input class="none custom-control-input" id="<% $name %>-none" type="<% $checktype %>" name="<% $name %>" value="" <% keys %default ? '' : ' checked="checked"' |n%> />
     <label class="custom-control-label" for="<% $name %>-none"><&|/l&>(no value)</&></label>
   </div>
 % }

share/static/js/util.js

@@ -1421,7 +1421,11 @@ jQuery(function () {
                 }
 
                 /* skip duplicates, such as ticket id */
-                if (currentForm.find('[name="' + field.attr('name') + '"]').length > 0) {
+                /* Specifically exclude radio and checkbox because the name of all inputs are the same
+                 * so checked values don't get properly submitted. This results in these CFs getting
+                 * unset when a field in another portlet is updated because the current value isn't
+                 * submitted. */
+                if (field.attr('type') != 'radio' && field.attr('type') != 'checkbox' && currentForm.find('[name="' + field.attr('name') + '"]').length > 0) {
                     return;
                 }