Skip to content

Commit f07dca2

Browse files
authored
Merge pull request #4 from bestit/feature/CTPBH-2507-add-74-support
CTPBh-2507 update the twig version for php 7.4 support
2 parents 0fa4081 + cfc5c35 commit f07dca2

File tree

4 files changed

+88
-18
lines changed

4 files changed

+88
-18
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"require": {
3131
"php": "^7.0",
3232
"symfony/symfony": "^3.1",
33-
"twig/twig": "1.24.*"
33+
"twig/twig": "v1.42.*"
3434
},
3535
"require-dev": {
3636
"squizlabs/php_codesniffer": "^2.7",

composer.lock

Lines changed: 79 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Twig/NodeModule/CollectAssetsCompiler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public function __construct(Twig_Node_Module $originalNode)
2727
$originalNode->lineno,
2828
$originalNode->tag
2929
);
30+
31+
$this->setSourceContext($originalNode->getSourceContext());
3032
}
3133

3234
/**

src/Twig/NodeVisitor/CollectAssetsNodeVisitor.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ protected function doEnterNode(Twig_Node $node, Twig_Environment $env): Twig_Nod
5656
}
5757

5858
if ($node instanceof Twig_Node_Include) {
59+
// Workaround to avoid empty template names for embed templates
60+
$name = $node->hasAttribute('name') ? $node->getAttribute('name') : null;
61+
if (empty($name)){
62+
$node->setAttribute('name', $node->getSourceContext()->getPath());
63+
}
64+
5965
$this->includes[] = $node->getNode('expr')->getAttribute('value');
6066
}
6167

0 commit comments

Comments
 (0)