PHPCS-242 No whitespace allowed before return type colon (backport)

Signed-off-by: Björn Lange <[email protected]>

Author: damyanovg

README.md

@@ -140,6 +140,8 @@ The base for the BestIt Standard is [PSR-12](https://github.com/php-fig/fig-stan
 | BestIt.Formatting.OpenTag.LineNotEmpty | The next line after the open tag MUST be empty. | no |
 | BestIt.Formatting.OpenTag.NoSpaceAfterOpenTag | There MUST be whitespace after the open tag. | no |
 | BestIt.Formatting.OpenTag.OpenTagNotFirstStatement | After the open tag there MUST be an empty line. | no |
+| BestIt.Formatting.ReturnTypeHintSpacingSniff.NoSpaceBetweenColonAndTypeHint | There MUST be no whitespace after the return type colon. |
+| BestIt.Formatting.ReturnTypeHintSpacingSniff.WhitespaceBeforeColon | There MUST be no whitespace before the return type colon. |
 | BestIt.Formatting.SpaceAfterDeclare.GroupBlankLineFound | Multiple declare-statements SHOULD be grouped without a blank line. | no |
 | BestIt.Formatting.SpaceAfterDeclare.MuchWhitespaceFound | THERE MUST be just one single line after the declare statement. | no |
 | BestIt.Formatting.SpaceAfterDeclare.NoWhitespaceFound | There MUST be one empty line after declare-statement. | no |

phpcs.xml.dist

@@ -4,7 +4,7 @@
 
     <rule ref="./src/Standards/BestIt/ruleset.xml" />
 
-    <config name="testVersion" value="7.1" />
+    <config name="testVersion" value="7.4" />
 
     <file>./build/</file>
     <file>./src/</file>

src/Standards/BestIt/Sniffs/Formatting/ReturnTypeHintSpacingSniff.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting;
+
+use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSpacingSniff as BaseReturnTypeHintSpacingSniff;
+
+/**
+ * Checks that there is no whitespace before the  return type.
+ *
+ * @author blange <[email protected]>
+ * @package BestIt\Sniffs\Formatting
+ */
+class ReturnTypeHintSpacingSniff extends BaseReturnTypeHintSpacingSniff
+{
+
+}

tests/Sniffs/Formatting/Fixtures/ReturnTypeHintSpacingSniff/correct/CorrectClass.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting\ReturnTypeHintSpacingSniff\Fixtures;
+
+class CorrectClass
+{
+    public function isCorrect(): bool
+    {
+        return true;
+    }
+}

tests/Sniffs/Formatting/Fixtures/ReturnTypeHintSpacingSniff/with_errors/NoSpaceBetweenColonAndTypeHint.9.fixed.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting\ReturnTypeHintSpacingSniff\Fixtures;
+
+class NoSpaceBetweenColonAndTypeHint
+{
+    public function isCorrect(): bool
+    {
+        return true;
+    }
+}

tests/Sniffs/Formatting/Fixtures/ReturnTypeHintSpacingSniff/with_errors/NoSpaceBetweenColonAndTypeHint.9.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting\ReturnTypeHintSpacingSniff\Fixtures;
+
+class NoSpaceBetweenColonAndTypeHint
+{
+    public function isCorrect():bool
+    {
+        return true;
+    }
+}

tests/Sniffs/Formatting/Fixtures/ReturnTypeHintSpacingSniff/with_errors/WhitespaceBeforeColon.9.fixed.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting\ReturnTypeHintSpacingSniff\Fixtures;
+
+class WhitespaceBeforeColon
+{
+    public function isCorrect(): bool
+    {
+        return true;
+    }
+}

tests/Sniffs/Formatting/Fixtures/ReturnTypeHintSpacingSniff/with_errors/WhitespaceBeforeColon.9.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting\ReturnTypeHintSpacingSniff\Fixtures;
+
+class WhitespaceBeforeColon
+{
+    public function isCorrect() : bool
+    {
+        return true;
+    }
+}

tests/Sniffs/Formatting/ReturnTypeHintSpacingSniffTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BestIt\Sniffs\Formatting;
+
+use BestIt\Sniffs\DefaultSniffIntegrationTestTrait;
+use BestIt\SniffTestCase;
+use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSpacingSniff as BaseReturnTypeHintSpacingSniff;
+
+/**
+ * Tests ReturnTypeHintSpacingSniff
+ *
+ * @author blange <[email protected]>
+ * @package BestIt\Sniffs\Formatting
+ */
+class ReturnTypeHintSpacingSniffTest extends SniffTestCase
+{
+    use DefaultSniffIntegrationTestTrait;
+
+    /**
+     * The tested class.
+     *
+     * @var ReturnTypeHintSpacingSniff
+     */
+    private $fixture;
+
+    /**
+     * Sets up the test.
+     *
+     * @return void
+     */
+    protected function setUp(): void
+    {
+        $this->fixture = new ReturnTypeHintSpacingSniff();
+    }
+
+    /**
+     * Checks the inheritance of  the class.
+     *
+     * @return void
+     */
+    public function testInstance(): void
+    {
+        static::assertInstanceOf(BaseReturnTypeHintSpacingSniff::class, $this->fixture);
+    }
+}