-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When batches expire, are we dealing with it correctly? #226
Comments
Right now we are not downloading the output or error files: |
And does not create a response fie: |
(1) The first thing we should do just allow for brute-force retry (aka run the same program again, Curator treats it as a completely failed batch and resubmits). (2) Then we should add the more fine-grained solution |
On (1) add an if statement when we check which batches are already submitted and don't mark as submitted if failed or expired or cancelled For the quickest fix, can just add to _submitted.jsonl. But maybe should write to _failed.jsonl and _expired.jsonl and should rewrite _submitted only with those not failed or expired?? can write all these files before each sleep |
We also want to resubmit requests that don't have a valid response format #86 (although very expensive to do if we resubmit the whole batch multiple times, so just submit failed requests) |
Should at least use the responses that have been completed.
Ofc the best thing would be to resubmit only requests that weren't completed.
Instead of resubmitting the whole batch that expired.
But the issue with this is now there isn't a 1 to 1 connection between requests --> batch --> responses. Keeping it simple we can just submit a smaller batch which is the remaining amount for that original batch.
The text was updated successfully, but these errors were encountered: