Merge pull request #183 from LazarDudic/master

berkayk · web-flow · commit 2eeca4d516ae · 2024-02-09T18:51:26.000+03:00
sendNotificationCustom is checking empty('include_external_user_ids')
diff --git a/src/OneSignalClient.php b/src/OneSignalClient.php
@@ -388,7 +388,7 @@ public function sendNotificationCustom($parameters = []){
         }
 
         // Make sure to use included_segments
-        if (empty($parameters['included_segments']) && empty($parameters['include_player_ids']) && empty('include_external_user_ids')) {
+        if (empty($parameters['included_segments']) && empty($parameters['include_player_ids']) && empty($parameters['include_external_user_ids'])) {
             $parameters['included_segments'] = ['All'];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ public function sendNotificationCustom($parameters = []){`
`388`	`388`	`}`
`389`	`389`
`390`	`390`	`// Make sure to use included_segments`
`391`		`- if (empty($parameters['included_segments']) && empty($parameters['include_player_ids']) && empty('include_external_user_ids')) {`
	`391`	`+ if (empty($parameters['included_segments']) && empty($parameters['include_player_ids']) && empty($parameters['include_external_user_ids'])) {`
`392`	`392`	`$parameters['included_segments'] = ['All'];`
`393`	`393`	`}`
`394`	`394`