Skip to content

Commit 4529907

Browse files
authored
hotfix: pgx transaction runtime panic if it is under a goroutine (#209)
1 parent 3428069 commit 4529907

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

api-server/services/deployment_revision.go

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818
"github.com/bentoml/yatai-schemas/modelschemas"
1919
"github.com/bentoml/yatai/api-server/models"
2020
"github.com/bentoml/yatai/common/consts"
21-
"github.com/bentoml/yatai/common/sync/errsgroup"
2221
"github.com/bentoml/yatai/common/utils"
2322
)
2423

@@ -374,19 +373,15 @@ func (s *deploymentRevisionService) Deploy(ctx context.Context, deploymentRevisi
374373
}
375374
}
376375

377-
var eg errsgroup.Group
378-
376+
// Can not use goroutine here because of pgx transaction bug
379377
for _, deploymentTarget := range deploymentTargets {
380-
deploymentTarget := deploymentTarget
381-
eg.Go(func() error {
382-
_, err := DeploymentTargetService.Deploy(ctx, deploymentTarget, deployOption)
383-
return err
384-
})
378+
_, err = DeploymentTargetService.Deploy(ctx, deploymentTarget, deployOption)
379+
if err != nil {
380+
return
381+
}
385382
}
386383

387-
err = eg.Wait()
388-
389-
return err
384+
return nil
390385
}
391386

392387
func (s *deploymentRevisionService) GetKubeCliSet(ctx context.Context, deploymentRevision *models.DeploymentRevision) (kubeCli *kubernetes.Clientset, restConfig *rest.Config, err error) {

0 commit comments

Comments
 (0)