Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if there are any level files which aren't used #271

Open
benthayer opened this issue Aug 8, 2020 · 2 comments
Open

Check to see if there are any level files which aren't used #271

benthayer opened this issue Aug 8, 2020 · 2 comments
Labels
testing Changes to test suites
Milestone

Comments

@benthayer
Copy link
Owner

Right now, the level template copies over several files which aren't necessarily used. For example, test.spec might not be used if a level is fairly simple, and filename.txt is copied over for the sake of an example, but is not likely to be used by most levels.

@benthayer benthayer added the testing Changes to test suites label Aug 8, 2020
@benthayer benthayer added this to the 1.x milestone Aug 8, 2020
@sahansk2
Copy link
Contributor

sahansk2 commented Aug 9, 2020

To clarify, is this an issue that deal with current levels, or is this a make_level.py issue? Dealing with files being copied over makes it seem like a make_level.py issue, but the issue title implies that we should run tests on pre-existing levels to see if they're using the files.

edit: Is this related to #272 ?

@benthayer
Copy link
Owner Author

This is unrelated to #272. This is also not really a make_level.py issue. The issue is really that make_level.py is being too helpful and is creating levels with everything you could possibly need, and you might forget to remove something if you don't need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Changes to test suites
Projects
None yet
Development

No branches or pull requests

2 participants