Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16 and remove prop-types from peer dependency #21

Open
gforge opened this issue Oct 28, 2017 · 3 comments
Open

Update to React 16 and remove prop-types from peer dependency #21

gforge opened this issue Oct 28, 2017 · 3 comments

Comments

@gforge
Copy link

gforge commented Oct 28, 2017

I'm getting warnings from yarn as below:

warning "[email protected]" has unmet peer dependency "prop-types@^15.5.8".
warning "[email protected]" has incorrect peer dependency "react@^15.5.4".

Would be nice if the package was updated to React 16

@kunokdev
Copy link

Any progress on this so far?

@findoo
Copy link
Contributor

findoo commented Dec 6, 2017

I've made a pull request for this #24

@soorajvnair
Copy link

I'm still getting a warning for prop-types and lodash.
screen shot 2018-02-20 at 5 44 13 pm

@bentatum Think it's a yarn issue. as detailed in the issues below
yarnpkg/yarn#4743
yarnpkg/yarn#4969

If i try with NPM all is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants