Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIData I/O #6

Open
benjaminpope opened this issue Feb 29, 2024 · 1 comment
Open

OIData I/O #6

benjaminpope opened this issue Feb 29, 2024 · 1 comment
Assignees

Comments

@benjaminpope
Copy link
Owner

I think the current solution for data I/O, using ImPlaneIA, is very clunky.

It is probably best to just wrap the quite good AMICAL interface.

Then I want the OIData to recognize at init time whether it has

  • {visibilities, squared visibilities}
  • {full phase, closure phase, no phase}

and appropriately define the likelihood function.

@benjaminpope
Copy link
Owner Author

We are now using pyoifits and OIData recognises this appropriately (PR #11), and this does the visibility and phase recognition as above.

A next feature is to make sure it correctly recognizes different formats of OIFITS data - @shashankdholakia has pointed out that we need to flatten CHARA data or do an outer product of baseline and wavelength to get the right dimensions for spectrally dispersed fringes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants