Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace onp, np with np, jnp #21

Open
benjaminpope opened this issue Apr 29, 2024 · 1 comment
Open

replace onp, np with np, jnp #21

benjaminpope opened this issue Apr 29, 2024 · 1 comment
Assignees

Comments

@benjaminpope
Copy link
Owner

@shashankdholakia has strong feelings that we should replace onp, np with np, jnp. I tend to agree. Opening this issue in case @LouisDesdoigts has strong feelings otherwise.

@LouisDesdoigts
Copy link
Collaborator

I tend to prefer the former, since I never really use normal numpy at all. From what I have seen of most jax code-bases import as np, unless there is large parts of the code that use normal numpy.

I would say we should probably just use whatever convention the other jax packages in the ecosystem near us use, but ultimately its preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants