Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop shape doesn't appear on iOS18 #22

Open
jrehbein opened this issue Sep 22, 2024 · 5 comments
Open

Crop shape doesn't appear on iOS18 #22

jrehbein opened this issue Sep 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jrehbein
Copy link

I'm updating an app I'm working on for iOS18, and have found that SwiftyCrop is broken on iOS18. With the latest version, the crop shape (I'm using square) isn't appearing and you can't pan the image as normal. I was previously using a version from April and it was broken on iOS18 in a different fashion.

I did see this error in the debugger when displaying SwiftyCrop:

[ERROR] Could not create a bookmark: NSError: Cocoa 4097 "connection to service named com.apple.FileProvider"

@benedom benedom added the bug Something isn't working label Sep 22, 2024
@benedom
Copy link
Owner

benedom commented Sep 22, 2024

Hey @jrehbein thanks for noticing and pointing this issue out. I will look into it asap!

@benedom
Copy link
Owner

benedom commented Sep 22, 2024

Okay I did some testing and I have the issue aswell in one of my apps using the library.

It seems to me however the mentioned console error is unrelated, since the image is loaded properly but the mask shape is just missing completely.

I added the same functionality for picking an image from the library using the PhotosPicker in the demo app. This also prints the same error in the console but the cropping works just fine.

I am still investigating but maybe this issue does not lay in the library itself but in the apps using the library.

@jrehbein
Copy link
Author

Yeah, I had no confidence that the error message was directly related, but just noted that it happened at the time of presenting the cropper in case it was.

Thanks for looking into this!

@benedom benedom added the wontfix This will not be worked on label Sep 25, 2024
@benedom benedom self-assigned this Sep 25, 2024
@benedom
Copy link
Owner

benedom commented Sep 25, 2024

I can confirm the following now:

  • The issue appears in iOS 18.0
  • Earlier versions (e.g. iOS 17) do not seem to be affected
  • Testing with iOS 18.1 (Beta 4) confirmed the issue to be resolved

In my understanding this is a SwiftUI bug in iOS 18.0. The solution is to update iOS 18.0 to 18.1 once released.

I am leaving this issue open for further notices and so others can find it.

@jrehbein
Copy link
Author

Thanks for verifying that. Unfortunate that it's an Apple bug (add it to the pile), but at least they are fixing this one. I wonder if the fix might actually be in 18.0.1? I'll be testing that out when that is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants